Re: Tab completion for GRANT MAINTAIN

2023-04-20 Thread Nathan Bossart
On Wed, Apr 19, 2023 at 10:54:05AM -0400, Tom Lane wrote: > (One could wish that it didn't take touching three or so places in > tab-complete.c to add a privilege, especially when a naive hacker might > think he was done after touching Privilege_options_of_grant_and_revoke. > I didn't see any easy

Re: Tab completion for GRANT MAINTAIN

2023-04-19 Thread Tom Lane
Jim Jones writes: > On 18.04.23 11:08, Ken Kato wrote: >> I found that GRANT MAINTAIN is not tab-completed with ON, so here is a >> patch. > I've marked the CF entry as "ready for committer" Yup, clearly an oversight. Pushed. (One could wish that it didn't take touching three or so places in

Re: Tab completion for GRANT MAINTAIN

2023-04-19 Thread Jim Jones
On 18.04.23 11:08, Ken Kato wrote: Hi hackers, I found that GRANT MAINTAIN is not tab-completed with ON, so here is a patch. Hi, the patch applies cleanly and now GRANT MAINTAIN tab-completes with ON. For the sake of completeness I tested a whole statement: postgres=# GRANT M =>

Tab completion for GRANT MAINTAIN

2023-04-18 Thread Ken Kato
Hi hackers, I found that GRANT MAINTAIN is not tab-completed with ON, so here is a patch. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index