Re: Table AM callback table_complete_speculative()'s succeeded argument is reversed

2019-05-14 Thread Andres Freund
Hi, On 2019-05-14 07:06:34 -0700, Andres Freund wrote: > On May 14, 2019 4:29:01 AM PDT, Heikki Linnakangas wrote: > >The 'succeeded' argument seems backwards here: > > > >> static void > >> heapam_tuple_complete_speculative(Relation relation, TupleTableSlot > >*slot, > >>

Re: Table AM callback table_complete_speculative()'s succeeded argument is reversed

2019-05-14 Thread Andres Freund
Hi, On May 14, 2019 4:29:01 AM PDT, Heikki Linnakangas wrote: >The 'succeeded' argument seems backwards here: > >> static void >> heapam_tuple_complete_speculative(Relation relation, TupleTableSlot >*slot, >>uint32 >> spekToken, bo

Table AM callback table_complete_speculative()'s succeeded argument is reversed

2019-05-14 Thread Heikki Linnakangas
The 'succeeded' argument seems backwards here: static void heapam_tuple_complete_speculative(Relation relation, TupleTableSlot *slot, uint32 spekToken, bool succeeded) { boolshouldFree = true; HeapTupl