On Fri, Jul 12, 2024 at 10:42 AM Ashutosh Bapat
wrote:
>
> I have merged the two patches now.
>
894be11adfa60ad1ce5f74534cf5f04e66d51c30 changed the schema in which
objects in test genereated_stored.sql are created. Because of this the
new test added by the patch was failing. Fixed the failure in
On Tue, Jul 9, 2024 at 1:07 PM Michael Paquier wrote:
>
> On Mon, Jul 08, 2024 at 03:59:30PM +0530, Ashutosh Bapat wrote:
> > Before submitting the patch, I looked for all the places which mention
> > AdjustUpgrade or AdjustUpgrade.pm to find places where the new module needs
> > to be mentioned.
On Mon, Jul 08, 2024 at 03:59:30PM +0530, Ashutosh Bapat wrote:
> Before submitting the patch, I looked for all the places which mention
> AdjustUpgrade or AdjustUpgrade.pm to find places where the new module needs
> to be mentioned. But I didn't find any. AdjustUpgrade is not mentioned
> in src/te
On Fri, Jul 5, 2024 at 10:59 AM Michael Paquier wrote:
> On Fri, Jun 28, 2024 at 06:00:07PM +0530, Ashutosh Bapat wrote:
> > Here's a description of patches and some notes
> > 0001
> > ---
> > 1. Per your suggestion the logic to handle dump output differences is
> > externalized in PostgreSQL
On Fri, Jun 28, 2024 at 06:00:07PM +0530, Ashutosh Bapat wrote:
> Here's a description of patches and some notes
> 0001
> ---
> 1. Per your suggestion the logic to handle dump output differences is
> externalized in PostgreSQL::Test::AdjustDump. Instead of eliminating those
> differences altoge
Sorry for delay, but here's next version of the patchset for review.
On Thu, Jun 6, 2024 at 5:07 AM Michael Paquier wrote:
> On Wed, Jun 05, 2024 at 05:09:58PM +0530, Ashutosh Bapat wrote:
> > Thanks for the suggestion. I didn't understand the dependency with the
> > buildfarm module. Will the n
On Wed, Jun 05, 2024 at 05:09:58PM +0530, Ashutosh Bapat wrote:
> Thanks for the suggestion. I didn't understand the dependency with the
> buildfarm module. Will the new module be used in buildfarm separately? I
> will work on this soon. Thanks for changing CF entry to WoA.
I had some doubts about
On Tue, Jun 4, 2024 at 4:28 AM Michael Paquier wrote:
> On Fri, Apr 26, 2024 at 06:38:22PM +0530, Ashutosh Bapat wrote:
> > Some points for discussion:
> > 1. The test still hardcodes the diffs between two dumps. Haven't found a
> > better way to do it. I did consider removing the problematic obj
On Fri, Apr 26, 2024 at 06:38:22PM +0530, Ashutosh Bapat wrote:
> Some points for discussion:
> 1. The test still hardcodes the diffs between two dumps. Haven't found a
> better way to do it. I did consider removing the problematic objects from
> the regression database but thought against it since
On Fri, Feb 23, 2024 at 10:46 AM Ashutosh Bapat <
ashutosh.bapat@gmail.com> wrote:
> On Thu, Feb 22, 2024 at 8:35 PM Tom Lane wrote:
> >
> > Peter Eisentraut writes:
> > > The problem is, we don't really have any end-to-end coverage of
> >
> > > dump
> > > restore
> > > dump again
> > > comp
On Thu, Feb 22, 2024 at 8:35 PM Tom Lane wrote:
>
> Peter Eisentraut writes:
> > The problem is, we don't really have any end-to-end coverage of
>
> > dump
> > restore
> > dump again
> > compare the two dumps
>
> > with a database with lots of interesting objects in it.
>
> I'm very much against
On Thu, Feb 22, 2024 at 3:50 PM Peter Eisentraut wrote:
>
> On 22.02.24 11:00, Daniel Gustafsson wrote:
> >> On 22 Feb 2024, at 10:55, Ashutosh Bapat
> >> wrote:
> >> On Thu, Feb 22, 2024 at 3:03 PM Daniel Gustafsson wrote:
> >
> >> Somebody looking for dump/restore tests wouldn't search
> >> s
Peter Eisentraut writes:
> The problem is, we don't really have any end-to-end coverage of
> dump
> restore
> dump again
> compare the two dumps
> with a database with lots of interesting objects in it.
I'm very much against adding another full run of the core regression
tests to support this.
On 22.02.24 11:00, Daniel Gustafsson wrote:
On 22 Feb 2024, at 10:55, Ashutosh Bapat wrote:
On Thu, Feb 22, 2024 at 3:03 PM Daniel Gustafsson wrote:
Somebody looking for dump/restore tests wouldn't search
src/bin/pg_upgrade, I think.
Quite possibly not, but pg_upgrade is already today an i
> On 22 Feb 2024, at 10:55, Ashutosh Bapat wrote:
> On Thu, Feb 22, 2024 at 3:03 PM Daniel Gustafsson wrote:
> Somebody looking for dump/restore tests wouldn't search
> src/bin/pg_upgrade, I think.
Quite possibly not, but pg_upgrade is already today an important testsuite for
testing pg_dump in
On Thu, Feb 22, 2024 at 3:03 PM Daniel Gustafsson wrote:
>
> > On 22 Feb 2024, at 10:16, Peter Eisentraut wrote:
>
> > We have somewhat relied on the pg_upgrade test to provide this testing, but
> > we have recently discovered that the dumps in binary-upgrade mode are
> > different enough to no
> On 22 Feb 2024, at 10:16, Peter Eisentraut wrote:
> We have somewhat relied on the pg_upgrade test to provide this testing, but
> we have recently discovered that the dumps in binary-upgrade mode are
> different enough to not test the normal dumps well.
>
> Yes, this test is a bit expensive.
On 22.02.24 02:01, Michael Paquier wrote:
On Wed, Feb 21, 2024 at 12:18:45PM +0530, Ashutosh Bapat wrote:
Even with 1 and 2 the test is useful to detect dump/restore anomalies.
I think we should improve 3, but I don't have a good and simpler
solution. I didn't find any way to compare two given c
On Thu, Feb 22, 2024 at 6:32 AM Michael Paquier wrote:
>
> On Wed, Feb 21, 2024 at 12:18:45PM +0530, Ashutosh Bapat wrote:
> > Even with 1 and 2 the test is useful to detect dump/restore anomalies.
> > I think we should improve 3, but I don't have a good and simpler
> > solution. I didn't find any
On Wed, Feb 21, 2024 at 12:18:45PM +0530, Ashutosh Bapat wrote:
> Even with 1 and 2 the test is useful to detect dump/restore anomalies.
> I think we should improve 3, but I don't have a good and simpler
> solution. I didn't find any way to compare two given clusters in our
> TAP test framework. Bu
Hi All,
In [1] we found that having a test to dump and restore objects left
behind by regression test is missing. Such a test would cover many
dump restore scenarios without much effort. It will also help identity
problems described in the same thread [2] during development itself.
I am starting
21 matches
Mail list logo
