Re: Testing DDL Deparser

2022-12-11 Thread Zheng Li
Hi, Thanks for working on this and for the feedback! I've added the updated deparser testing module to the DDL replication thread in [1]. We'll add more test cases to the testing module and continue the discussion there. [1] https://www.postgresql.org/message-id/CAAD30U%2BA%3D2rjZ%2BxejNz%2Be1

Re: Testing DDL Deparser

2022-10-24 Thread Alvaro Herrera
On 2022-Oct-20, Runqi Tian wrote: > My question regarding subcommand is actually on commands other than > ALTER TABLE. Let me give an example (You can also find this example in > the patch), when command like > > CREATE SCHEMA element_test CREATE TABLE foo (id int) > > is caught by ddl_command_e

Re: Testing DDL Deparser

2022-10-20 Thread Runqi Tian
Hello: Many thanks for providing feedbacks and sorry for late reply. I updated the testing harness, please apply patches in [1] before apply the attached patch. >Not clear on what this means. Are you talking about ALTER TABLE >subcommands? If so, then what you have to do (ISTM) is construct a >si

Re: Testing DDL Deparser

2022-10-06 Thread Alvaro Herrera
Hello Overall, many thanks for working on this. I hope that the objectives can be fulfilled, so that we can have dependable DDL replication soon. I haven't read the patch at all, so I can't comment on what you've done, but I have comments to some of your questions: On 2022-Oct-05, Runqi Tian wr

Testing DDL Deparser

2022-10-06 Thread Runqi Tian
Hello: I’m working on developing a testing harness for the DDL Deparser being worked on in [1], please apply the patches in [1] before apply this patch. I think the testing harness needs to achieve the following goals: 1. The deparsed JSON output is as expected. 2. The SQL commands re-formed from