On Tue, Nov 5, 2019 at 11:19 PM Tom Lane wrote:
>
> Fujii Masao writes:
> > I'm thinking to commit the patch. But I have one question; is it ok to
> > back-patch? Since the patch changes the command tags for some commands,
> > for example, which might break the existing event trigger functions
>
Fujii Masao writes:
> I'm thinking to commit the patch. But I have one question; is it ok to
> back-patch? Since the patch changes the command tags for some commands,
> for example, which might break the existing event trigger functions
> using TG_TAG if we back-patch it. Or we should guarantee
On Sat, Nov 2, 2019 at 4:40 PM Michael Paquier wrote:
>
> On Fri, Nov 01, 2019 at 02:17:03PM +0500, Ibrar Ahmed wrote:
> > Do we really need a regression test cases for such small oversights?
>
> It is possible to get the command tags using an event trigger... But
> that sounds hack-ish.
Yes,
On Fri, Nov 01, 2019 at 02:17:03PM +0500, Ibrar Ahmed wrote:
> Do we really need a regression test cases for such small oversights?
It is possible to get the command tags using an event trigger... But
that sounds hack-ish.
--
Michael
signature.asc
Description: PGP signature
On Fri, Nov 1, 2019 at 8:00 AM Fujii Masao wrote:
> On Fri, Nov 1, 2019 at 6:34 AM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Oct 31, 2019 at 6:56 PM Tom Lane wrote:
> >>
> >> Fujii Masao writes:
> >> > ... I found that the command tag
On Fri, Nov 1, 2019 at 6:34 AM Ibrar Ahmed wrote:
>
>
>
> On Thu, Oct 31, 2019 at 6:56 PM Tom Lane wrote:
>>
>> Fujii Masao writes:
>> > ... I found that the command tag of
>> > ALTER MATERIALIZED VIEW RENAME COLUMN is "ALTER TABLE", not "
On Thu, Oct 31, 2019 at 6:56 PM Tom Lane wrote:
> Fujii Masao writes:
> > ... I found that the command tag of
> > ALTER MATERIALIZED VIEW RENAME COLUMN is "ALTER TABLE", not "ALTER VIEW".
>
> > =# ALTER MATERIALIZED VIEW ho
Fujii Masao writes:
> ... I found that the command tag of
> ALTER MATERIALIZED VIEW RENAME COLUMN is "ALTER TABLE", not "ALTER VIEW".
> =# ALTER MATERIALIZED VIEW hoge RENAME COLUMN j TO x;
> ALTER TABLE
> Is this intentiona
LIZED VIEW
=# ALTER MATERIALIZED VIEW test RENAME TO hoge;
ALTER MATERIALIZED VIEW
This is ok and looks intuitive to users. But I found that the command tag of
ALTER MATERIALIZED VIEW RENAME COLUMN is "ALTER TABLE", not "ALTER VIEW".
=# ALTER MATERIALIZED VIEW hoge RENAME
