Re: The two "XML Fixes" patches still in need of review

2019-03-23 Thread Chapman Flack
On 03/23/19 18:20, Chapman Flack wrote: > On 03/23/19 17:05, Tom Lane wrote: >> I've now pushed a somewhat-adjusted version of the XML-content fix >> patch. The documentation patch needs some small rebasing to apply >> after that one instead of before it. > > Will do. > >> Perhaps it'd make sens

Re: The two "XML Fixes" patches still in need of review

2019-03-23 Thread Chapman Flack
On 03/23/19 18:20, Chapman Flack wrote: >> Perhaps it'd make sense under the XML section in datatype.sgml, >> but I think I might lean to making it a new section in Appendix D >> (SQL Conformance). > > Sounds like the option (4) I proposed back in [1]. I suppose it won't > be much trouble to move.

Re: The two "XML Fixes" patches still in need of review

2019-03-23 Thread Chapman Flack
On 03/23/19 17:05, Tom Lane wrote: > Just to update this thread --- per the other thread at > https://postgr.es/m/can-v+g-6jquqeqz55q3toxen6d5ez5uvzl4vr+8ktvjkj31...@mail.gmail.com > I've now pushed a somewhat-adjusted version of the XML-content fix > patch. The documentation patch needs some sma

Re: The two "XML Fixes" patches still in need of review

2019-03-23 Thread Tom Lane
Chapman Flack writes: > Alvaro has committed two of the patches in this CF entry[1], but the > remaining two have yet to attract review. > This message contains only those two, just as before[2] except rebased > over Alvaro's commits of the others. Just to update this thread --- per the other thr

The two "XML Fixes" patches still in need of review

2019-03-07 Thread Chapman Flack
Alvaro has committed two of the patches in this CF entry[1], but the remaining two have yet to attract review. This message contains only those two, just as before[2] except rebased over Alvaro's commits of the others. There are two new changes. The s added in the -docfix patch now have link t