Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-13 Thread Andrew Dunstan
On 1/13/19 9:24 AM, Tom Lane wrote: > Andrew Dunstan writes: >> On 1/12/19 2:03 PM, Tom Lane wrote: >>> I wonder if it's practical to scrape DLSUFFIX out of src/Makefile.port >>> instead of listing all the possibilities here. >> I'd rather get make to tell us directly, something like: >> .PH

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-13 Thread Tom Lane
Andrew Dunstan writes: > On 1/12/19 2:03 PM, Tom Lane wrote: >> I wonder if it's practical to scrape DLSUFFIX out of src/Makefile.port >> instead of listing all the possibilities here. > I'd rather get make to tell us directly, something like: > .PHONY: show_dl_suffix > show_dl_suffix: >

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-13 Thread Andrew Dunstan
On 1/12/19 2:03 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 1/11/19 6:33 PM, Tom Lane wrote: >>> While I think I've fixed this bug, I'm still quite confused about why >>> only some buildfarm animals showed the problem. >> ... Is there something weird about naming of library files on HP-UX

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-12 Thread Tom Lane
Andrew Dunstan writes: > On 1/11/19 6:33 PM, Tom Lane wrote: >> While I think I've fixed this bug, I'm still quite confused about why >> only some buildfarm animals showed the problem. > ... Is there something weird about naming of library files on HP-UX? Doh! I looked right at this code last n

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-12 Thread Andrew Dunstan
On 1/11/19 6:33 PM, Tom Lane wrote: > I wrote: >> So it appears that in v10, >> ./configure ... --enable-tap-tests ... >> make >> make install >> cd contrib/test_decoding >> make check >> fails due to failure to install test_decoding into the tmp_install >> tree, while it

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-11 Thread Tom Lane
I wrote: > So it appears that in v10, > ./configure ... --enable-tap-tests ... > make > make install > cd contrib/test_decoding > make check > fails due to failure to install test_decoding into the tmp_install > tree, while it works in v11. Moreover, that's not specif

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-11 Thread Tom Lane
I wrote: > There's no obvious difference between bedda9fbb and 6dd690be3, > so I surmise that that patch depended somehow on some previous > work that only went into v11 not v10. Haven't found what, yet. Ah, looks like it was 42e61c774. I'll push a fix shortly. regards,

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-11 Thread Tom Lane
I wrote: > Thomas Munro writes: >> Does this mean it didn't build the test_decoding module? > I'm wondering if it built it but didn't install it, as a result of > some problem with >> bedda9fbb7 Mon Dec 31 21:57:57 2018 UTC Process EXTRA_INSTALL >> serially, during the first temp-install. So it

Re: Three animals fail test-decoding-check on REL_10_STABLE

2019-01-11 Thread Tom Lane
Thomas Munro writes: > Only gaur shows useful logs: > SELECT 'init' FROM > pg_create_logical_replication_slot('regression_slot', > 'test_decoding'); > ! ERROR: could not access file "test_decoding": No such file or directory > Does this mean it didn't build the test_decoding module? I'm wond

Three animals fail test-decoding-check on REL_10_STABLE

2019-01-11 Thread Thomas Munro
Hi, Only gaur shows useful logs: SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding'); ! ERROR: could not access file "test_decoding": No such file or directory Does this mean it didn't build the test_decoding module? Of the failing animals, damselfly bui