Re: Track statistics for streaming of in-progress transactions

2020-10-29 Thread Amit Kapila
On Thu, Oct 29, 2020 at 5:16 AM Tomas Vondra wrote: > > On Wed, Oct 28, 2020 at 08:54:53AM +0530, Amit Kapila wrote: > >On Fri, Oct 23, 2020 at 10:24 AM Amit Kapila wrote: > >> > >> On Thu, Oct 22, 2020 at 2:09 PM Amit Kapila > >> wrote: > >> > > >> > >> I have fixed the above comment and

Re: Track statistics for streaming of in-progress transactions

2020-10-28 Thread Tomas Vondra
On Wed, Oct 28, 2020 at 08:54:53AM +0530, Amit Kapila wrote: On Fri, Oct 23, 2020 at 10:24 AM Amit Kapila wrote: On Thu, Oct 22, 2020 at 2:09 PM Amit Kapila wrote: > I have fixed the above comment and rebased the patch. I have changed the docs a bit to add more explanation about the

Re: Track statistics for streaming of in-progress transactions

2020-10-27 Thread Amit Kapila
On Fri, Oct 23, 2020 at 10:24 AM Amit Kapila wrote: > > On Thu, Oct 22, 2020 at 2:09 PM Amit Kapila wrote: > > > > I have fixed the above comment and rebased the patch. I have changed > the docs a bit to add more explanation about the counters. Let me know > if you have any more comments. Thanks

Re: Track statistics for streaming of in-progress transactions

2020-10-22 Thread Amit Kapila
On Thu, Oct 22, 2020 at 2:09 PM Amit Kapila wrote: > > On Thu, Oct 22, 2020 at 11:52 AM Dilip Kumar wrote: > > > > On Wed, Oct 14, 2020 at 9:09 AM Amit Kapila wrote: > > > > > > Commit 464824323e has added the support of the streaming of > > > in-progress transactions into the built-in logical

Re: Track statistics for streaming of in-progress transactions

2020-10-22 Thread Amit Kapila
On Thu, Oct 22, 2020 at 11:52 AM Dilip Kumar wrote: > > On Wed, Oct 14, 2020 at 9:09 AM Amit Kapila wrote: > > > > Commit 464824323e has added the support of the streaming of > > in-progress transactions into the built-in logical replication. The > > attached patch adds the statistics about

Re: Track statistics for streaming of in-progress transactions

2020-10-22 Thread Dilip Kumar
On Wed, Oct 14, 2020 at 9:09 AM Amit Kapila wrote: > > Commit 464824323e has added the support of the streaming of > in-progress transactions into the built-in logical replication. The > attached patch adds the statistics about transactions streamed to the > decoding output plugin from

Re: Track statistics for streaming of in-progress transactions

2020-10-22 Thread Ajin Cherian
On Tue, Oct 20, 2020 at 4:29 PM Amit Kapila wrote: > Thanks. One thing I have considered while updating this patch was to > write a test case similar to what we have for spilled stats in > test_decoding/sql/stats.sql but I decided not to do it as that doesn't > seem to add much value for the

Re: Track statistics for streaming of in-progress transactions

2020-10-20 Thread Amit Kapila
On Wed, Oct 21, 2020 at 8:15 AM Masahiko Sawada wrote: > > On Tue, 20 Oct 2020 at 14:29, Amit Kapila wrote: > > > > > > Thanks. One thing I have considered while updating this patch was to > > write a test case similar to what we have for spilled stats in > > test_decoding/sql/stats.sql but I

Re: Track statistics for streaming of in-progress transactions

2020-10-20 Thread Masahiko Sawada
On Tue, 20 Oct 2020 at 14:29, Amit Kapila wrote: > > On Mon, Oct 19, 2020 at 1:52 PM Ajin Cherian wrote: > > > > On Wed, Oct 14, 2020 at 2:39 PM Amit Kapila wrote: > > > > > > Commit 464824323e has added the support of the streaming of > > > in-progress transactions into the built-in logical

Re: Track statistics for streaming of in-progress transactions

2020-10-19 Thread Amit Kapila
On Mon, Oct 19, 2020 at 1:52 PM Ajin Cherian wrote: > > On Wed, Oct 14, 2020 at 2:39 PM Amit Kapila wrote: > > > > Commit 464824323e has added the support of the streaming of > > in-progress transactions into the built-in logical replication. The > > attached patch adds the statistics about

Re: Track statistics for streaming of in-progress transactions

2020-10-19 Thread Ajin Cherian
On Wed, Oct 14, 2020 at 2:39 PM Amit Kapila wrote: > > Commit 464824323e has added the support of the streaming of > in-progress transactions into the built-in logical replication. The > attached patch adds the statistics about transactions streamed to the > decoding output plugin from

Track statistics for streaming of in-progress transactions

2020-10-13 Thread Amit Kapila
Commit 464824323e has added the support of the streaming of in-progress transactions into the built-in logical replication. The attached patch adds the statistics about transactions streamed to the decoding output plugin from ReorderBuffer. Users can query the pg_stat_replication_slots view to