Re: Turn TransactionIdRetreat/Advance into inline functions

2022-10-10 Thread Tom Lane
Maxim Orlov writes: >> -1. Having to touch all the call sites like this outweighs >> any claimed advantage: it makes them uglier and it will greatly >> complicate any back-patching we might have to do in those areas. > Ok, got it. But what if we change the semantics of these calls to > xid =

Re: Turn TransactionIdRetreat/Advance into inline functions

2022-10-10 Thread Maxim Orlov
> -1. Having to touch all the call sites like this outweighs > any claimed advantage: it makes them uglier and it will greatly > complicate any back-patching we might have to do in those areas. > > regards, tom lane > Ok, got it. But what if we change the semantics of

Re: Turn TransactionIdRetreat/Advance into inline functions

2022-10-10 Thread Tom Lane
Maxim Orlov writes: > I've notice recent activity to convert macros into inline functions. We > should make TransactionIdRetreat/Advance functions > Instead of a macro, should we? -1. Having to touch all the call sites like this outweighs any claimed advantage: it makes them uglier and it will

Turn TransactionIdRetreat/Advance into inline functions

2022-10-10 Thread Maxim Orlov
Hi! This patch is inspired by [0] and many others. I've notice recent activity to convert macros into inline functions. We should make TransactionIdRetreat/Advance functions Instead of a macro, should we? I also think about NormalTransactionIdPrecedes and NormalTransactionIdFollows, but maybe,