Re: Typos in the code and README

On Mon, 21 Apr 2025 at 11:21, Michael Paquier wrote: > Thanks for sharing the command able to spot all these. I just pushed a few more. The previous regex didn't account for the duplicate word being on the next line. I dug up the following to find the ones just committed in 78eda9e26. ag "\s([a-

Re: Typos in the code and README

On Mon, Apr 21, 2025 at 10:42:19AM +1200, David Rowley wrote: > On Sun, 20 Apr 2025 at 13:32, David Rowley wrote: >> Here are a few more fixes of a similar ilk. All new in 2025, >> predominantly from the last few days before feature freeze. > > I've pushed those ones. Thanks for sharing the comm

Re: Typos in the code and README

On Sun, 20 Apr 2025 at 13:32, David Rowley wrote: > Here are a few more fixes of a similar ilk. All new in 2025, > predominantly from the last few days before feature freeze. I've pushed those ones. David

Re: Typos in the code and README

On Sat, 19 Apr 2025 at 20:00, Alexander Lakhin wrote: > I've gathered the following collection of typos and inconsistencies > appeared since 2025-01-01: Here are a few more fixes of a similar ilk. All new in 2025, predominantly from the last few days before feature freeze. The few I wasn't a ful

Re: Typos in the code and README

Hello Michael, 19.04.2025 13:04, Michael Paquier wrote: Good finds, Alexander, particularly for the set of function and variable names used in the comments that do not match with the reality. I've checked all these, and they're good for me. Thank you for your attention to this! GIN_TUPLE_ -

Re: Typos in the code and README

On Sat, Apr 19, 2025 at 11:00:00AM +0300, Alexander Lakhin wrote: > I've gathered the following collection of typos and inconsistencies > appeared since 2025-01-01: Good finds, Alexander, particularly for the set of function and variable names used in the comments that do not match with the realit

Re: Typos in the code and README

Hello hackers, I've gathered the following collection of typos and inconsistencies appeared since 2025-01-01: aio_worker.c -> method_worker.c amcheck_lock_relation -> amcheck_lock_relation_and_check be_key -> be_cancel_key belonds -> belongs cann -> can CheckConstraintFetch -> CheckNNConstra

Re: Typos in the code and README

On Thu, 2 Jan 2025 at 05:00, Alexander Lakhin wrote: > Please look at another collection of typos and inconsistencies introduced > during 2024: The fixes all look good to me. I see some are mine, so I will take care of pushing. Thanks for the patch. David

Re: Typos in the code and README

Hello hackers, 03.09.2024 08:51, Michael Paquier wrote: And done that. Please look at another collection of typos and inconsistencies introduced during 2024: behvior -> behavior contraint -> constraint curent -> current disable_node -> disabled_nodes disabled_node > disabled_nodes disable

Re: Typos in the code and README

> On 4 Sep 2024, at 17:34, David Rowley wrote: > > On Wed, 4 Sept 2024 at 20:24, Daniel Gustafsson wrote: >> Not mandatory at all, but since you were prepping a typo backpatch anyways I >> figured these could join to put a small dent in reducing risks for future >> backports. > > I think this i

Re: Typos in the code and README

On Thu, Sep 05, 2024 at 03:34:31AM +1200, David Rowley wrote: > Anyway, I doubt hard > guidelines are warranted here, but maybe some hints about best > practices in https://wiki.postgresql.org/wiki/Committing_checklist ? Yep, that may be useful. I just tend to be cautious because it can be very e

Re: Typos in the code and README

On Wed, 4 Sept 2024 at 20:24, Daniel Gustafsson wrote: > Not mandatory at all, but since you were prepping a typo backpatch anyways I > figured these could join to put a small dent in reducing risks for future > backports. I think this is pretty good logic. I think fixing comment typos in ancien

Re: Typos in the code and README

> On 4 Sep 2024, at 03:25, Michael Paquier wrote: > > On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote: >> I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169 >> from >> just now contains 2 (out of 3) sets of typos introduced in v17 so they should >> follow

Re: Typos in the code and README

On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote: > I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169 from > just now contains 2 (out of 3) sets of typos introduced in v17 so they should > follow along when you push the ones mentioned here. Is that really m

Re: Typos in the code and README

> On 3 Sep 2024, at 07:51, Michael Paquier wrote: > > On Tue, Sep 03, 2024 at 02:24:32PM +0900, Michael Paquier wrote: >> On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote: >>> I've gathered another bunch of defects with the possible substitutions. >>> Please take a look: >>> pgsta

Re: Typos in the code and README

On Tue, Sep 03, 2024 at 02:24:32PM +0900, Michael Paquier wrote: > On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote: > > I've gathered another bunch of defects with the possible substitutions. > > Please take a look: > > pgstat_add_kind -> pgstat_register_kind (see 7949d9594) > > A

Re: Typos in the code and README

On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote: > I've gathered another bunch of defects with the possible substitutions. > Please take a look: > pgstat_add_kind -> pgstat_register_kind (see 7949d9594) And here I thought I took care of these inconsistencies. This one is on me so

Re: Typos in the code and README

Hello, 12.08.2024 14:59, David Rowley wrote: (I know Daniel mentioned he'd get to these, but the ScanDirection one was my fault and I needed to clear that off my mind. I did a few others while on this topic.) Thank you, David, for working on that! I've gathered another bunch of defects with t

Re: Typos in the code and README

(I know Daniel mentioned he'd get to these, but the ScanDirection one was my fault and I needed to clear that off my mind. I did a few others while on this topic.) On Fri, 5 Jul 2024 at 05:00, Alexander Lakhin wrote: > Please look at another bunch of inconsistencies/orphaned entities I found > in

Re: Typos in the code and README

> On 4 Jul 2024, at 19:00, Alexander Lakhin wrote: > Please look at another bunch of inconsistencies/orphaned entities I found > in the tree, with the possible substitutions: Thanks for these, and sorry for the delay in processing them (summer happened etc). I've started to go through them and

Re: Typos in the code and README

Hello hackers, 03.05.2024 17:36, David Rowley wrote: I pushed the patch after only adjusting the path in the docs which had "module" rather than "modules". Please look at another bunch of inconsistencies/orphaned entities I found in the tree, with the possible substitutions: errmsg_buf -> erro

Re: Typos in the code and README

On Fri, 3 May 2024 at 00:00, Alexander Lakhin wrote: > (some of them are located in doc/, so it's not a code-only change) > I've attached the patch for your convenience, though maybe some > of the suggestions are to be discarded. Thanks. I was hoping you'd do that. I pushed the patch after only

Re: Typos in the code and README

Hello, 28.04.2024 11:05, David Rowley wrote: On Sat, 20 Apr 2024 at 16:09, David Rowley wrote: Here are a few more to see if it motivates anyone else to do a more thorough search for another batch. I've pushed these now. Please look also at the list of other typos and inconsistencies I've

Re: Typos in the code and README

On Sat, 20 Apr 2024 at 16:09, David Rowley wrote: > Here are a few more to see if it motivates anyone else to do a more > thorough search for another batch. I've pushed these now. David

Re: Typos in the code and README

On Fri, 19 Apr 2024 at 20:13, Daniel Gustafsson wrote: > Thanks, I incorporated these into 0001 before pushing. All the commits in > this > patchset are now applied. Here are a few more to see if it motivates anyone else to do a more thorough search for another batch. Fixes duplicate words spa

Re: Typos in the code and README

> On 16 Apr 2024, at 15:37, Nazir Bilal Yavuz wrote: > I realized two small typos: 'sgmr' -> 'smgr'. You may want to include > them in 0001. Thanks, I incorporated these into 0001 before pushing. All the commits in this patchset are now applied. -- Daniel Gustafsson

Re: Typos in the code and README

Hi, Thanks for working on this! On Mon, 15 Apr 2024 at 15:26, Daniel Gustafsson wrote: > > > On 14 Apr 2024, at 13:19, David Rowley wrote: > > > > On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote: > >> > >>> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: > >>> Here's a few more. I'v

Re: Typos in the code and README

On Mon, Apr 15, 2024 at 8:26 PM Daniel Gustafsson wrote: > Thanks. Collecting all the ones submitted here, as well as a few submitted > off-list by Alexander, the patch is now a 3-part patchset of cleanups: > > 0001 contains the typos and duplicate words fixups, 0002 fixes a parameter > with > t

Re: Typos in the code and README

> On 14 Apr 2024, at 13:19, David Rowley wrote: > > On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote: >> >>> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: >>> Here's a few more. I've accumulate these over the past couple of months, >>> keeping them stashed in a branch, adding to it

Re: Typos in the code and README

On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote: > > > On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: > > Here's a few more. I've accumulate these over the past couple of months, > > keeping them stashed in a branch, adding to it whenever I've spotted a > > minor typo while reading t

Re: Typos in the code and README

> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: > > On 11/04/2024 16:05, Daniel Gustafsson wrote: >> Now that the tree has settled down a bit post-freeze I ran some tooling to >> check spelling. I was primarily interested in docs and README* which were >> mostly free from simply typos, whi

Re: Typos in the code and README

On 11/04/2024 16:05, Daniel Gustafsson wrote: Now that the tree has settled down a bit post-freeze I ran some tooling to check spelling. I was primarily interested in docs and README* which were mostly free from simply typos, while the code had some in various comments and one in code. The atta

Re: Typos in the code and README

On Fri, Apr 12, 2024 at 04:55:16PM -0400, Bruce Momjian wrote: > On Thu, Apr 11, 2024 at 03:37:00PM +0200, Daniel Gustafsson wrote: > > On 11 Apr 2024, at 15:29, David Rowley wrote: > > > > On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote: > > > > Now that the tree has sett

Re: Typos in the code and README

On Thu, Apr 11, 2024 at 03:37:00PM +0200, Daniel Gustafsson wrote: > On 11 Apr 2024, at 15:29, David Rowley wrote: > > On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote: > > Now that the tree has settled down a bit post-freeze I ran some > tooling > to > che

Re: Typos in the code and README

> On 11 Apr 2024, at 15:29, David Rowley wrote: > > On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, > wrote: >> Now that the tree has settled down a bit post-freeze I ran some tooling to >> check spelling. I was primarily interested in docs and README* which were >> most

Re: Typos in the code and README

On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote: > Now that the tree has settled down a bit post-freeze I ran some tooling to > check spelling. I was primarily interested in docs and README* which were > mostly free from simply typos, while the code had some in various comments > and > one

Re: Typos in the code and README

On 2024-04-11 Th 09:05, Daniel Gustafsson wrote: Now that the tree has settled down a bit post-freeze I ran some tooling to check spelling. I was primarily interested in docs and README* which were mostly free from simply typos, while the code had some in various comments and one in code. The

Typos in the code and README

Now that the tree has settled down a bit post-freeze I ran some tooling to check spelling. I was primarily interested in docs and README* which were mostly free from simply typos, while the code had some in various comments and one in code. The attached fixes all that I came across (not cross-ref