Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-09-14 Thread Tom Lane
Bharath Rupireddy writes: > Merged. PSA v8 patch set. Pushed, thanks. regards, tom lane

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-23 Thread Bharath Rupireddy
On Thu, Jul 21, 2022 at 9:50 AM Kyotaro Horiguchi wrote: > > At Wed, 20 Jul 2022 17:25:33 +0530, Bharath Rupireddy > wrote in > > On Wed, Jul 20, 2022 at 12:55 PM Kyotaro Horiguchi > > wrote: > > PSA v7 patch set. > > Thanks. Looks perfect, but (sorry..) in the final checking, I found > "log

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-20 Thread Kyotaro Horiguchi
At Wed, 20 Jul 2022 17:25:33 +0530, Bharath Rupireddy wrote in > On Wed, Jul 20, 2022 at 12:55 PM Kyotaro Horiguchi > wrote: > PSA v7 patch set. Thanks. Looks perfect, but (sorry..) in the final checking, I found "log archive" in the doc. If you agree to it please merge the attached (or

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-20 Thread Bharath Rupireddy
On Wed, Jul 20, 2022 at 12:55 PM Kyotaro Horiguchi wrote: > > At Wed, 20 Jul 2022 10:02:22 +0530, Bharath Rupireddy > wrote in > > Done. PSA v6 patch set. > > Thanks! > > -Specifies the minimum size of past log file segments kept in the > +Specifies the minimum size of past WAL

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-20 Thread Kyotaro Horiguchi
At Wed, 20 Jul 2022 10:02:22 +0530, Bharath Rupireddy wrote in > Done. PSA v6 patch set. Thanks! -Specifies the minimum size of past log file segments kept in the +Specifies the minimum size of past WAL files kept in the -log file by reducing the value of this

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-19 Thread Bharath Rupireddy
On Wed, Jul 20, 2022 at 6:55 AM Kyotaro Horiguchi wrote: > > At Tue, 19 Jul 2022 09:58:28 -0700, Nathan Bossart > wrote in > > On Tue, Jul 19, 2022 at 02:43:59PM +0530, Bharath Rupireddy wrote: > > > Done. PSA v5 patch set. > > > > LGTM. I've marked this as ready-for-committer. > > I find the

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-19 Thread Kyotaro Horiguchi
At Tue, 19 Jul 2022 09:58:28 -0700, Nathan Bossart wrote in > On Tue, Jul 19, 2022 at 02:43:59PM +0530, Bharath Rupireddy wrote: > > Done. PSA v5 patch set. > > LGTM. I've marked this as ready-for-committer. I find the following sentense in config.sgml. "Specifies the minimum size of past

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-19 Thread Nathan Bossart
On Tue, Jul 19, 2022 at 02:43:59PM +0530, Bharath Rupireddy wrote: > Done. PSA v5 patch set. LGTM. I've marked this as ready-for-committer. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-19 Thread Bharath Rupireddy
On Tue, Jul 19, 2022 at 12:00 AM Nathan Bossart wrote: > > Overall, these patches look reasonable. > > On Mon, Jul 18, 2022 at 04:24:12PM +0530, Bharath Rupireddy wrote: > > record. Because the entire content of data pages is saved in the > > - log on the first page modification after a

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-18 Thread Nathan Bossart
Overall, these patches look reasonable. On Mon, Jul 18, 2022 at 04:24:12PM +0530, Bharath Rupireddy wrote: > record. Because the entire content of data pages is saved in the > - log on the first page modification after a checkpoint (assuming > + WAL record on the first page modification

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-07-18 Thread Bharath Rupireddy
On Tue, Apr 26, 2022 at 1:24 AM Nathan Bossart wrote: > > It's been a few weeks, so I'm marking the commitfest entry as > waiting-on-author. Thanks. I'm attaching the updated v4 patches (also subsumed Kyotaro San's patch at [1]). Please review it further. [1]

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-04-25 Thread Nathan Bossart
It's been a few weeks, so I'm marking the commitfest entry as waiting-on-author. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-04-01 Thread Nathan Bossart
On Fri, Apr 01, 2022 at 10:31:10AM +0900, Kyotaro Horiguchi wrote: > you should at least save the contents of the cluster's > pg_wal > - subdirectory, as it might contain logs which > + subdirectory, as it might contain WAL files which > were not archived before the system

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-03-31 Thread Kyotaro Horiguchi
At Thu, 31 Mar 2022 08:45:56 -0700, Nathan Bossart wrote in > At all times, PostgreSQL maintains a > write ahead log (WAL) in the > pg_wal/ > - subdirectory of the cluster's data directory. The log records > - every change made to the database's data files. This log exists > +

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-03-31 Thread Nathan Bossart
At all times, PostgreSQL maintains a write ahead log (WAL) in the pg_wal/ - subdirectory of the cluster's data directory. The log records - every change made to the database's data files. This log exists + subdirectory of the cluster's data directory. The WAL records + capture

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-03-26 Thread Bharath Rupireddy
On Wed, Mar 2, 2022 at 11:41 AM Bharath Rupireddy wrote: > > Please review the v2 patch set. Had to rebase. Attaching v3 patch set. Regards, Bharath Rupireddy. v3-0001-Use-WAL-segment-instead-of-log-segment.patch Description: Binary data

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-03-01 Thread Bharath Rupireddy
On Tue, Mar 1, 2022 at 6:50 AM Kyotaro Horiguchi wrote: > > At Mon, 28 Feb 2022 21:03:07 +0530, Bharath Rupireddy > wrote in > > Hi, > > > > It looks like we use "log segment" in various user-facing messages. > > The term "log" can mean server logs as well. The "WAL segment" suits > > well here

Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-02-28 Thread Kyotaro Horiguchi
At Mon, 28 Feb 2022 21:03:07 +0530, Bharath Rupireddy wrote in > Hi, > > It looks like we use "log segment" in various user-facing messages. > The term "log" can mean server logs as well. The "WAL segment" suits > well here and it is consistently used across the other user-facing > messages

Use "WAL segment" instead of "log segment" consistently in user-facing messages

2022-02-28 Thread Bharath Rupireddy
Hi, It looks like we use "log segment" in various user-facing messages. The term "log" can mean server logs as well. The "WAL segment" suits well here and it is consistently used across the other user-facing messages [1]. Here's a small patch attempting to consistently use the "WAL segment".