Re: Using AF_UNIX sockets always for tests on Windows

2024-02-01 Thread vignesh C
On Sun, 21 Jan 2024 at 18:01, vignesh C wrote: > > On Wed, 22 Mar 2023 at 09:59, Thomas Munro wrote: > > > > Thanks Tom, Andres, Juan José, Andrew for your feedback. I agree that > > it's a better "OS harmonisation" outcome if we can choose both ways on > > both OSes. I will leave the 0003

Re: Using AF_UNIX sockets always for tests on Windows

2024-01-21 Thread vignesh C
On Wed, 22 Mar 2023 at 09:59, Thomas Munro wrote: > > Thanks Tom, Andres, Juan José, Andrew for your feedback. I agree that > it's a better "OS harmonisation" outcome if we can choose both ways on > both OSes. I will leave the 0003 patch aside for now due to lack of > time, but here's a rebase

Re: Using AF_UNIX sockets always for tests on Windows

2023-03-21 Thread Thomas Munro
Thanks Tom, Andres, Juan José, Andrew for your feedback. I agree that it's a better "OS harmonisation" outcome if we can choose both ways on both OSes. I will leave the 0003 patch aside for now due to lack of time, but here's a rebase of the first two patches. Since this is really just more

Re: Using AF_UNIX sockets always for tests on Windows

2023-01-16 Thread Juan José Santamaría Flecha
Hello, On Fri, Dec 2, 2022 at 1:03 AM Thomas Munro wrote: > > 1. Teach mkdtemp() to make a non-world-accessible directory. This is > required to be able to make a socket that other processes can't > connect to, to match the paranoia level used on Unix. This was > written just by reading

Re: Using AF_UNIX sockets always for tests on Windows

2023-01-05 Thread Andrew Dunstan
On 2023-01-04 We 07:13, vignesh C wrote: > On Fri, 2 Dec 2022 at 18:08, Andrew Dunstan wrote: >> >> On 2022-12-01 Th 21:10, Andres Freund wrote: >>> Hi, >>> >>> On 2022-12-01 20:56:18 -0500, Tom Lane wrote: Andres Freund writes: > On 2022-12-01 20:30:36 -0500, Tom Lane wrote: >>

Re: Using AF_UNIX sockets always for tests on Windows

2023-01-04 Thread vignesh C
On Fri, 2 Dec 2022 at 18:08, Andrew Dunstan wrote: > > > On 2022-12-01 Th 21:10, Andres Freund wrote: > > Hi, > > > > On 2022-12-01 20:56:18 -0500, Tom Lane wrote: > >> Andres Freund writes: > >>> On 2022-12-01 20:30:36 -0500, Tom Lane wrote: > If we remove that, won't we have a whole lot

Re: Using AF_UNIX sockets always for tests on Windows

2022-12-02 Thread Andrew Dunstan
On 2022-12-01 Th 21:10, Andres Freund wrote: > Hi, > > On 2022-12-01 20:56:18 -0500, Tom Lane wrote: >> Andres Freund writes: >>> On 2022-12-01 20:30:36 -0500, Tom Lane wrote: If we remove that, won't we have a whole lot of code that's not tested at all on any platform, ie all the

Re: Using AF_UNIX sockets always for tests on Windows

2022-12-01 Thread Andres Freund
Hi, On 2022-12-01 20:56:18 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2022-12-01 20:30:36 -0500, Tom Lane wrote: > >> If we remove that, won't we have a whole lot of code that's not > >> tested at all on any platform, ie all the TCP-socket code? > > > There's some coverage via the

Re: Using AF_UNIX sockets always for tests on Windows

2022-12-01 Thread Tom Lane
Andres Freund writes: > On 2022-12-01 20:30:36 -0500, Tom Lane wrote: >> If we remove that, won't we have a whole lot of code that's not >> tested at all on any platform, ie all the TCP-socket code? > There's some coverage via the auth and ssl tests. But I agree it's an > issue. But to me the

Re: Using AF_UNIX sockets always for tests on Windows

2022-12-01 Thread Andres Freund
Hi, On 2022-12-01 20:30:36 -0500, Tom Lane wrote: > Thomas Munro writes: > > Commit f5580882 established that all supported computers have AF_UNIX. > > One of the follow-up consequences that was left unfinished is that we > > could simplify our test harness code to make it the same on all > >

Re: Using AF_UNIX sockets always for tests on Windows

2022-12-01 Thread Tom Lane
Thomas Munro writes: > Commit f5580882 established that all supported computers have AF_UNIX. > One of the follow-up consequences that was left unfinished is that we > could simplify our test harness code to make it the same on all > platforms. Currently we have hundreds of lines of C and perl

Using AF_UNIX sockets always for tests on Windows

2022-12-01 Thread Thomas Munro
Hi, Commit f5580882 established that all supported computers have AF_UNIX. One of the follow-up consequences that was left unfinished is that we could simplify our test harness code to make it the same on all platforms. Currently we have hundreds of lines of C and perl to use secure TCP