Re: Why not try for a HOT update, even when PageIsFull()?

2021-11-26 Thread Peter Geoghegan
On Sun, Nov 21, 2021 at 4:29 PM Peter Geoghegan wrote: > On Fri, Nov 19, 2021 at 11:51 AM Alvaro Herrera > wrote: > > I certainly do not object to removing it. > > I'd like to do so soon. I'll wait a few more days, in case Pavan objects. Pushed just now. Thanks -- Peter Geoghegan

Re: Why not try for a HOT update, even when PageIsFull()?

2021-11-21 Thread Peter Geoghegan
On Fri, Nov 19, 2021 at 11:51 AM Alvaro Herrera wrote: > Hmm, I don't have any memory of introducing this; and if you look at the > thread, you'll notice that it got there between the first patch I posted > and the second one, without any mention of the reason. I probably got > that code from

Re: Why not try for a HOT update, even when PageIsFull()?

2021-11-19 Thread Alvaro Herrera
On 2021-Nov-17, Peter Geoghegan wrote: > Commit 2fd8685e7f simplified the checking of modified attributes that > takes place within heap_update(). This included a micro-optimization > that affects pages marked PageIsFull(): when the target page is marked > with PD_PAGE_FULL (which must have been

Why not try for a HOT update, even when PageIsFull()?

2021-11-17 Thread Peter Geoghegan
Commit 2fd8685e7f simplified the checking of modified attributes that takes place within heap_update(). This included a micro-optimization that affects pages marked PageIsFull(): when the target page is marked with PD_PAGE_FULL (which must have been set by a previous heap_update call), don't even