Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-03-07 Thread Alvaro Herrera
On 2018-Jul-08, Markus Winand wrote: > Hi! > > > I have pushed the patch now (in your original form rather than my later > > formulation) -- let's see how the buildfarm likes it. There are (at > > least) three issues remaining, as per below; Pavel, do you have any > > insight on these? > > Atta

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-02-28 Thread Chapman Flack
Hi, thanks for checking the patches! On 02/28/19 19:36, Ramanarayana wrote: > The below statement needs to be executed before running the query to > replicate the issue > > update xmldata set data = regexp_replace(data::text, '791', > '791')::xml; If you are applying that update (and there is a

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-02-28 Thread Ramanarayana
Hi, The below statement needs to be executed before running the query to replicate the issue update xmldata set data = regexp_replace(data::text, '791', '791')::xml; On Thu, 28 Feb 2019 at 17:55, Pavel Stehule wrote: > > > čt 28. 2. 2019 v 10:31 odesílatel Pavel Stehule > napsal: > >> >> >> čt

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-02-28 Thread Pavel Stehule
čt 28. 2. 2019 v 10:31 odesílatel Pavel Stehule napsal: > > > čt 28. 2. 2019 v 9:58 odesílatel Ramanarayana > napsal: > >> Hi, >> >> I have tested the three issues fixed in patch 001. Array Indexes >> issue is still there.Running the following query returns ERROR: more >> than one value

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-02-28 Thread Pavel Stehule
čt 28. 2. 2019 v 10:49 odesílatel Ramanarayana napsal: > Hi, > I applied the following patches > > 0001-XML-XPath-comments-processing-instructions-array-ind.patch > > > 0002-XM

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-02-28 Thread Ramanarayana
Hi, I applied the following patches 0001-XML-XPath-comments-processing-instructions-array-ind.patch 0002-XML-avoid-xmlStrdup-if-possible.patch

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-02-28 Thread Pavel Stehule
čt 28. 2. 2019 v 9:58 odesílatel Ramanarayana napsal: > Hi, > > I have tested the three issues fixed in patch 001. Array Indexes > issue is still there.Running the following query returns ERROR: more than > one value returned by column XPath expression > > SELECT xmltable.* > FROM (SELECT

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2019-02-28 Thread Ramanarayana
> > Hi, I have tested the three issues fixed in patch 001. Array Indexes issue is still there.Running the following query returns ERROR: more than one value returned by column XPath expression SELECT xmltable.* FROM (SELECT data FROM xmldata) x, LATERAL XMLTABLE('/ROWS/ROW' PASSING data C

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2018-06-21 Thread Alvaro Herrera
I have pushed the patch now (in your original form rather than my later formulation) -- let's see how the buildfarm likes it. There are (at least) three issues remaining, as per below; Pavel, do you have any insight on these? First one is about array indexes not working sanely (I couldn't get thi

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2018-06-20 Thread Alvaro Herrera
Hi On 2018-Mar-27, Markus Winand wrote: > I’ve found two issues with XML/XPath integration in PostgreSQL. Two > patches are attached. I’ve just separated them because the second one > is an incompatible change. > > * Patch 0001: Accept TEXT and CDATA nodes in XMLTABLE’s column_expression. I pus

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2018-06-19 Thread Alvaro Herrera
Hello hackers, Any objections fixing this on Pg11? My opinion is that it's better to fix it now rather than waiting for pg12. It's already broken in pg10 (xmltable) and older (rest of the xml stuff). As Markus advised, I'd not backpatch fixes for fear of breaking stuff, but I'd rather release p

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2018-04-30 Thread Markus Winand
Hi and thanks for your efforts. > On 2018-04-26, at 21:18 , Alvaro Herrera wrote: > > Hello Markus, > > Markus Winand wrote: > >> * Patch 0001: Accept TEXT and CDATA nodes in XMLTABLE’s column_expression. >> >>> Column_expressions that match TEXT or CDATA nodes must return >>> the contents of

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2018-04-26 Thread Alvaro Herrera
Hello Markus, Markus Winand wrote: > * Patch 0001: Accept TEXT and CDATA nodes in XMLTABLE’s column_expression. > > > Column_expressions that match TEXT or CDATA nodes must return > > the contents of the node itself, not the content of the > > non-existing childs (i.e. the empty string). > > Th

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2018-03-27 Thread Alvaro Herrera
Markus Winand wrote: Hi Markus, > I’ve found two issues with XML/XPath integration in PostgreSQL. Two > patches are attached. I’ve just separated them because the second one > is an incompatible change. Thanks for these. I'll have a look at them after the commitfest is over. In the meantime, i