On Fri, Sep 2, 2022 at 4:07 AM Tom Lane wrote:
> Pushed with some revisions. Notably, I didn't see any point in
> repeating each test case four times, so I trimmed it down to once
> per case.
I checked it.
Thank you for correcting it in a better way.
Dong Wook Lee writes:
> I modified my previous patch by reflecting the feedback.
> and I wrote most of the queries for the test after looking at the file below.
Pushed with some revisions. Notably, I didn't see any point in
repeating each test case four times, so I trimmed it down to once
per ca
I modified my previous patch by reflecting the feedback.
and I wrote most of the queries for the test after looking at the file below.
- ref:
(https://github.com/postgres/postgres/blob/master/src/test/isolation/specs/tuplelock-conflict.spec)
The coverage of the test is approximately 81.5%.
If t
2022년 7월 31일 (일) 오전 6:32, Tom Lane 님이 작성:
>
> Dong Wook Lee writes:
> > I just wrote test about pg_rowlocks extension.
> > I added sql and spec test for locking state.
>
> I think this could be cut down quite a bit. Do we really need
> both a SQL test and an isolation test? Seems like you could
Dong Wook Lee writes:
> I just wrote test about pg_rowlocks extension.
> I added sql and spec test for locking state.
I think this could be cut down quite a bit. Do we really need
both a SQL test and an isolation test? Seems like you could
easily do everything in the isolation test.
Also, it i
Hi Hackers,
I just wrote test about pg_rowlocks extension.
I added sql and spec test for locking state.
---
Regards
DongWook Lee
diff --git a/contrib/pgrowlocks/Makefile b/contrib/pgrowlocks/Makefile
index 294c05dd0f..128f345b7e 100644
--- a/contrib/pgrowlocks/Makefile
+++ b/contrib/pgrowlocks/Ma
