Re: alter subscription drop publication fixes

On Fri, Jun 25, 2021 at 1:30 PM Peter Eisentraut wrote: > > On 15.05.21 15:15, vignesh C wrote: > > Thanks Bharath, that looks good. I have added a commitfest entry at [1] > > and marked it to Ready For Committer. > > [1] - https://commitfest.postgresql.org/33/3115/ > >

Re: alter subscription drop publication fixes

On 15.05.21 15:15, vignesh C wrote: Thanks Bharath, that looks good. I have added a commitfest entry at [1] and marked it to Ready For Committer. [1] - https://commitfest.postgresql.org/33/3115/ Committed. I took out some of the code reformatting.

Re: alter subscription drop publication fixes

On Sat, May 15, 2021 at 2:58 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > On Fri, May 14, 2021 at 11:02 PM vignesh C wrote: > > > > On Fri, May 14, 2021 at 8:56 PM Tom Lane wrote: > > > > > > Bharath Rupireddy writes: > > > > On Fri, May 14, 2021 at 7:58 PM vignesh C

Re: alter subscription drop publication fixes

On Fri, May 14, 2021 at 11:02 PM vignesh C wrote: > > On Fri, May 14, 2021 at 8:56 PM Tom Lane wrote: > > > > Bharath Rupireddy writes: > > > On Fri, May 14, 2021 at 7:58 PM vignesh C wrote: > > >> I have changed it to: > > >> ADD adds additional publications, > > >> - DROP removes publica

Re: alter subscription drop publication fixes

ist, ADD adds additional publications to the list of publications and DROP removes the publications from the list of publications. Attached patch has the change for the same. Thoughts? Regards, Vignesh From 4f887b0b3f338f55d186fa059cfdc255b9783263 Mon Sep 17 00:00:00 2001 From: vignesh Date: Fri, 14

Re: alter subscription drop publication fixes

Bharath Rupireddy writes: > On Fri, May 14, 2021 at 7:58 PM vignesh C wrote: >> I have changed it to: >> ADD adds additional publications, >> - DROP removes publications from the list of >> + DROP removes publications to/from the list of > How about "Publications are added to or droppe

Re: alter subscription drop publication fixes

On Fri, May 14, 2021 at 7:58 PM vignesh C wrote: > I have changed it to: >ADD adds additional publications, > - DROP removes publications from the list of > + DROP removes publications to/from the list of How about "Publications are added to or dropped from the existing list of

Re: alter subscription drop publication fixes

On Fri, May 14, 2021 at 7:41 AM Japin Li wrote: > > > On Thu, 13 May 2021 at 22:13, vignesh C wrote: > > On Wed, May 12, 2021 at 10:15 PM Bharath Rupireddy > > wrote: > >> > >> On Wed, May 12, 2021 at 9:55 PM vignesh C wrote: > >> > While I was reviewing one of the logical decoding features, I

Re: alter subscription drop publication fixes

ame. I also made another change to change set_publication_option to publication_option as it is common for SET/ADD & DROP. Regards, Vignesh From 3b477122f909d5e1df35c32a1775665bc92ec86b Mon Sep 17 00:00:00 2001 From: vignesh Date: Fri, 14 May 2021 19:30:40 +0530 Subject: [PATCH v3] Fixes in alter subscription drop

Re: alter subscription drop publication fixes

On Thu, 13 May 2021 at 22:13, vignesh C wrote: > On Wed, May 12, 2021 at 10:15 PM Bharath Rupireddy > wrote: >> >> On Wed, May 12, 2021 at 9:55 PM vignesh C wrote: >> > While I was reviewing one of the logical decoding features, I found a >> > few issues in alter subscription drop publication.

Re: alter subscription drop publication fixes

On Thu, May 13, 2021 at 7:43 PM vignesh C wrote: > I have separated the Drop publication documentation contents. There > are some duplicate contents but the readability is slightly better. > Thoughts? -ALTER SUBSCRIPTION name DROP PUBLICATION publication_name [, ...] [ WITH ( set_publication_opti

Re: alter subscription drop publication fixes

the readability is slightly better. Thoughts? > > merge_publications can be called after validation of the options > > specified, I think we should check if the options specified are > > correct or not before checking the actual publications. > > +1. That was a miss in the origi

Re: alter subscription drop publication fixes

On Thu, May 13, 2021 at 9:36 AM Bharath Rupireddy wrote: > > On Thu, May 13, 2021 at 8:45 AM Japin Li wrote: > > >> Dropping all the publications present in the subscription using alter > > >> subscription drop publication would throw "subscription must contain > > >> at least one publication". T

Re: alter subscription drop publication fixes

On Thu, May 13, 2021 at 8:45 AM Japin Li wrote: > >> Dropping all the publications present in the subscription using alter > >> subscription drop publication would throw "subscription must contain > >> at least one publication". This message was slightly confusing to me. > >> As even though some p

Re: alter subscription drop publication fixes

On Thu, 13 May 2021 at 00:45, Bharath Rupireddy wrote: > On Wed, May 12, 2021 at 9:55 PM vignesh C wrote: >> While I was reviewing one of the logical decoding features, I found a >> few issues in alter subscription drop publication. > > Thanks! > >> Alter subscription drop publication does not

Re: alter subscription drop publication fixes

On Wed, May 12, 2021 at 9:55 PM vignesh C wrote: > While I was reviewing one of the logical decoding features, I found a > few issues in alter subscription drop publication. Thanks! > Alter subscription drop publication does not support copy_data option, > that needs to be removed from tab compl

alter subscription drop publication fixes

actual publications. Attached a patch which contains the fixes for the same. Thoughts? Regards, Vignesh From 516f7b933f06b64ebb21e3f55bdd223703879a3a Mon Sep 17 00:00:00 2001 From: vignesh Date: Mon, 10 May 2021 12:15:28 +0530 Subject: [PATCH v1] Fixes in alter subscription drop publicat