Re: amcheck is using a wrong macro to check compressed-ness

2022-06-23 Thread Michael Paquier
On Wed, Jun 22, 2022 at 01:14:57PM -0400, Robert Haas wrote: > Oops, I missed this thread. I think the patch is correct, so I have > committed it. Thanks, Robert. -- Michael signature.asc Description: PGP signature

Re: amcheck is using a wrong macro to check compressed-ness

2022-06-22 Thread Robert Haas
On Tue, Jun 21, 2022 at 9:56 PM Michael Paquier wrote: > On Thu, Jun 09, 2022 at 10:48:27AM +0900, Michael Paquier wrote: > > Three weeks later, ping. Robert, could you look at this thread? > > And again. beta2 is planned to next week, and this is still an open > item. I could look at that by m

Re: amcheck is using a wrong macro to check compressed-ness

2022-06-21 Thread Michael Paquier
On Thu, Jun 09, 2022 at 10:48:27AM +0900, Michael Paquier wrote: > Three weeks later, ping. Robert, could you look at this thread? And again. beta2 is planned to next week, and this is still an open item. I could look at that by myself, but I always tend to get easily confused with all the VARA

Re: amcheck is using a wrong macro to check compressed-ness

2022-06-08 Thread Michael Paquier
On Wed, May 18, 2022 at 09:55:07AM +0900, Michael Paquier wrote: > On Tue, May 17, 2022 at 04:58:11PM +0900, Michael Paquier wrote: >> Adding Robert in CC, as this has been added with bd807be. I have >> added an open item for now. > > With the individual in CC, that's even better. Three weeks la

Re: amcheck is using a wrong macro to check compressed-ness

2022-05-17 Thread Michael Paquier
On Tue, May 17, 2022 at 04:58:11PM +0900, Michael Paquier wrote: > Adding Robert in CC, as this has been added with bd807be. I have > added an open item for now. With the individual in CC, that's even better. -- Michael signature.asc Description: PGP signature

Re: amcheck is using a wrong macro to check compressed-ness

2022-05-17 Thread Michael Paquier
On Tue, May 17, 2022 at 04:27:19PM +0900, Kyotaro Horiguchi wrote: > What do you think about the attached? The problem code is new in > PG15. Adding Robert in CC, as this has been added with bd807be. I have added an open item for now. -- Michael signature.asc Description: PGP signature

amcheck is using a wrong macro to check compressed-ness

2022-05-17 Thread Kyotaro Horiguchi
Hello. While I looked into a patch, I noticed that check_tuple_attribute does not run the check for compessed data even if a compressed data is given. check_tuple_attribute() .. struct varatt_external toast_pointer; .. VARATT_EXTERNAL_GET_POINTER(toast_pointer, attr); .. i