Re: assert in nested SQL procedure call in current HEAD

On 12.07.18 18:43, Andres Freund wrote: > On 2018-06-29 13:52:23 +0200, Peter Eisentraut wrote: >> From 95fc7156afe521b715fab08d44606774df875e92 Mon Sep 17 00:00:00 2001 >> From: Peter Eisentraut >> Date: Fri, 29 Jun 2018 13:28:39 +0200 >> Subject: [PATCH] Fix assert in nested SQL procedure call

Re: assert in nested SQL procedure call in current HEAD

On 12.06.18 18:47, Andrew Gierth wrote: > While testing this, I ran into another semi-related issue: > shmem_exit_inprogress isn't ever being cleared in the postmaster, which > means that if you ever have a crash-restart, any attempt to do a > rollback in a procedure will then crash or get some

Re: assert in nested SQL procedure call in current HEAD

Hi, On 2018-06-29 13:52:23 +0200, Peter Eisentraut wrote: > From 95fc7156afe521b715fab08d44606774df875e92 Mon Sep 17 00:00:00 2001 > From: Peter Eisentraut > Date: Fri, 29 Jun 2018 13:28:39 +0200 > Subject: [PATCH] Fix assert in nested SQL procedure call Andrew, Peter, are you happy with this?

Re: assert in nested SQL procedure call in current HEAD

On 12.06.18 18:47, Andrew Gierth wrote: > While testing this, I ran into another semi-related issue: > shmem_exit_inprogress isn't ever being cleared in the postmaster, which > means that if you ever have a crash-restart, any attempt to do a > rollback in a procedure will then crash or get some

Re: assert in nested SQL procedure call in current HEAD

On 6/27/18 18:51, Peter Eisentraut wrote: > On 6/27/18 17:44, Andres Freund wrote: >> This hasn't progressed in a while. Peter, since you committed the >> relevant change, could you update us please? > > I've been on vacation for a bit. I will work on this next. I hope to > have a solution in a

Re: assert in nested SQL procedure call in current HEAD

On 6/27/18 17:44, Andres Freund wrote: > This hasn't progressed in a while. Peter, since you committed the > relevant change, could you update us please? I've been on vacation for a bit. I will work on this next. I hope to have a solution in a few days. -- Peter Eisentraut

Re: assert in nested SQL procedure call in current HEAD

Hi Peter, On 2018-06-10 21:06:59 +0200, Dmitry Dolgov wrote: > > On 8 June 2018 at 06:20, Andrew Gierth wrote: > > > Joe> My colleague Yogesh Sharma discovered an assert in nested SQL > > Joe> procedure calls after ROLLBACK is used. Minimal test case and > > Joe> backtrace below. I have not

Re: assert in nested SQL procedure call in current HEAD

> "Peter" == Peter Eisentraut writes: >> Did you miss the fact that the issue only occurs when the top-level >> procedure does a rollback? The problem is not with nested calls, but >> rather with the fact that commit or rollback is leaving >> ActiveSnapshot unset, which is (as Tom

Re: assert in nested SQL procedure call in current HEAD

On 6/12/18 10:03, Andrew Gierth wrote: >> "Peter" == Peter Eisentraut writes: > > Peter> The problem with these nested procedure calls is that if the > Peter> nested call > > Did you miss the fact that the issue only occurs when the top-level > procedure does a rollback? The problem is

Re: assert in nested SQL procedure call in current HEAD

> "Peter" == Peter Eisentraut writes: Peter> The problem with these nested procedure calls is that if the Peter> nested call Did you miss the fact that the issue only occurs when the top-level procedure does a rollback? The problem is not with nested calls, but rather with the fact that

Re: assert in nested SQL procedure call in current HEAD

On 6/10/18 15:06, Dmitry Dolgov wrote: >> I added it to the open items list since nobody else seems to have taken >> notice; from Tom's linked message it seems this should be Peter E's bag? > I've taken a look at this - indeed, the situation looks similar to what > described in the linked message,

Re: assert in nested SQL procedure call in current HEAD

> On 8 June 2018 at 06:20, Andrew Gierth wrote: > Joe> My colleague Yogesh Sharma discovered an assert in nested SQL > Joe> procedure calls after ROLLBACK is used. Minimal test case and > Joe> backtrace below. I have not yet tried to figure out exactly what > Joe> is going on beyond seeing

Re: assert in nested SQL procedure call in current HEAD

> "Andrew" == Andrew Gierth writes: > "Joe" == Joe Conway writes: Joe> My colleague Yogesh Sharma discovered an assert in nested SQL Joe> procedure calls after ROLLBACK is used. Minimal test case and Joe> backtrace below. I have not yet tried to figure out exactly what Joe> is

Re: assert in nested SQL procedure call in current HEAD

> "Joe" == Joe Conway writes: Joe> My colleague Yogesh Sharma discovered an assert in nested SQL Joe> procedure calls after ROLLBACK is used. Minimal test case and Joe> backtrace below. I have not yet tried to figure out exactly what Joe> is going on beyond seeing

assert in nested SQL procedure call in current HEAD

My colleague Yogesh Sharma discovered an assert in nested SQL procedure calls after ROLLBACK is used. Minimal test case and backtrace below. I have not yet tried to figure out exactly what is going on beyond seeing that it occurs in pg_plan_query() where the comment says "Planner must have a