Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Alvaro Herrera
Christoph Berg wrote: > Re: Alvaro Herrera 2018-03-20 <20180320185038.r3hjvfio4elnaqku@alvherre.pgsql> > > Time::HiRes is also in libperl5.24, so as far Debian goes, that one > > would be unnecessary; but IPC::Run and Test::More are in separate > > packages (libipc-run-perl and libtest-base-perl, r

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Christoph Berg
Re: Alvaro Herrera 2018-03-20 <20180320185038.r3hjvfio4elnaqku@alvherre.pgsql> > Time::HiRes is also in libperl5.24, so as far Debian goes, that one > would be unnecessary; but IPC::Run and Test::More are in separate > packages (libipc-run-perl and libtest-base-perl, respectively.) The Debian pack

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Tom Lane
Andres Freund writes: > It's also certainly annoying that AX_PROG_PERL_MODULES doesn't support > caching. Yeah, that was the main reason I didn't want to add wholesale module probing. Improving that script is no doubt possible, but it's beyond what I care to do about the issue.

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Andres Freund
On 2018-03-20 17:23:26 +, Dagfinn Ilmari Mannsåker wrote: > Tom Lane writes: > > That seems like expensive overkill to me, especially since it seems > > unlikely that we'd keep the list up-to-date over time. > > The patches uptread add about 0.2s to a 6.9s configure run here, I don't > consi

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Dagfinn Ilmari Mannsåker
Alvaro Herrera writes: > Tom Lane wrote: > >> Ah, thanks. Not sure we need to make an explicit test for Opcode; we've >> not heard of anyone not having that. > > In Debian stable, Opcode is in package libperl5.24. This probably > explains why nobody runs into trouble with it, since libperl is a

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Ah, thanks. Not sure we need to make an explicit test for Opcode; we've >> not heard of anyone not having that. > In Debian stable, Opcode is in package libperl5.24. This probably > explains why nobody runs into trouble with it, since libperl is alrea

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Alvaro Herrera
Tom Lane wrote: > ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > > Tom Lane writes: > >> I just want to test for modules that we know are likely to be omitted > >> on popular platforms. I've proposed testing two that would improve > >> the user experience on Red Hat; what

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Tom Lane writes: >> I just want to test for modules that we know are likely to be omitted >> on popular platforms. I've proposed testing two that would improve >> the user experience on Red Hat; what's the equivalent minimum

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> Tom Lane writes: >>> ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: I think the other way would be better simpler: we require a complete Perl core installation. > >>> And

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Tom Lane writes: >> ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >>> I think the other way would be better simpler: we require a complete >>> Perl core installation. >> And you propose to test for tha

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> Tom Lane writes: >>> Ah-hah. So it seems to me that it'd be a useful exercise to start >>> from perl-base and find out what has to be added to get to working >>> TAP tests. Anyone? > >> I think the othe

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Tom Lane writes: >> Ah-hah. So it seems to me that it'd be a useful exercise to start >> from perl-base and find out what has to be added to get to working >> TAP tests. Anyone? > I think the other way would be better simpl

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> Note that Fedora aren't the only ones to do this: Debian also splits the >> Perl core dist into multiple packages. The crucial difference is that >> on Debian installing the 'perl' package gives you the w

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Note that Fedora aren't the only ones to do this: Debian also splits the > Perl core dist into multiple packages. The crucial difference is that > on Debian installing the 'perl' package gives you the whole lot, while > on Fed

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-20 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > Craig Ringer writes: >> On 19 March 2018 at 23:56, Tom Lane wrote: >>> ... much excavation finds a complaint about Time::HiRes not being installed > >> That's absurd. Time::HiRes is a core module, as is Test::More. Sigh. > >> Yes, looks like tests are necessary. I'd argue it'

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-19 Thread Michael Paquier
On Mon, Mar 19, 2018 at 10:54:59PM -0400, Chapman Flack wrote: > Ehh, I'm with Craig. The *perl project* identifies which packages (and > versions) are part of perl core in each perl version ... not Red Hat. > > http://cpansearch.perl.org/src/BINGOS/Module-CoreList-5.20180220/lib/Module/CoreList.p

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-19 Thread Chapman Flack
On 03/19/18 22:40, Tom Lane wrote: > Craig Ringer writes: >> Yes, looks like tests are necessary. I'd argue it's "test for broken Perl" >> but apparently Fedora think they should split the Perl core dist into tiny >> pieces. > > FWIW, the package boundaries are the same on RHEL6, and probably lon

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-19 Thread Tom Lane
Craig Ringer writes: > On 19 March 2018 at 23:56, Tom Lane wrote: >> ... much excavation finds a complaint about Time::HiRes not being installed > That's absurd. Time::HiRes is a core module, as is Test::More. Sigh. > Yes, looks like tests are necessary. I'd argue it's "test for broken Perl" >

Re: configure's checks for --enable-tap-tests are insufficient

2018-03-19 Thread Craig Ringer
On 19 March 2018 at 23:56, Tom Lane wrote: $ make -j check-world > ... runs for awhile and then fails > ... much excavation finds a complaint about Time::HiRes not being installed > $ sudo yum install perl-Time-HiRes > > That's absurd. Time::HiRes is a core module, as is Test::More. Sigh. Yes, l

configure's checks for --enable-tap-tests are insufficient

2018-03-19 Thread Tom Lane
So I just went through a rather annoying process trying to run check-world on a Fedora 26 box where I hadn't done it before: $ ./configure --enable-tap-tests ... fails, whining about IPC::Run $ sudo yum install perl-IPC-Run $ ./configure --enable-tap-tests ... fails, whining about prove ... figure