On 05.12.20 03:22, Michael Paquier wrote:
On Fri, Dec 04, 2020 at 02:34:26PM +0100, Peter Eisentraut wrote:
On 2020-12-02 15:04, Alvaro Herrera wrote:
I do wonder if it'd be a good idea to move the syscall
name itself out of the message, too; that would reduce the number of
messages to
On Fri, Dec 04, 2020 at 02:34:26PM +0100, Peter Eisentraut wrote:
> On 2020-12-02 15:04, Alvaro Herrera wrote:
>> I do wonder if it'd be a good idea to move the syscall
>> name itself out of the message, too; that would reduce the number of
>> messages to translate 50x to just "%s(%s) failed: %m"
On 2020-12-03 08:55, Noah Misch wrote:
For the changes I didn't mention explicitly (most of them), I'm -0.5. Many of
them "can't happen", use source code terms of art, and/or breach guideline
"Avoid mentioning called function names, either; instead say what the code was
trying to do"
On 2020-12-03 08:02, Michael Paquier wrote:
+ else
+ ereport(LOG,
+ (errmsg("checkpoint starting:%s%s%s%s%s%s%s%s",
Would it be better to add a note for translators here, in short that
all those %s are options related to checkpoint/restartpoints?
done
The ones in
On 2020-12-02 15:04, Alvaro Herrera wrote:
- elog(LOG, "WSAIoctl(SIO_KEEPALIVE_VALS) failed: %ui",
-WSAGetLastError());
+ ereport(LOG,
+ (errmsg("WSAIoctl(SIO_KEEPALIVE_VALS) failed:
%ui",
+
On Wed, Dec 02, 2020 at 02:26:24PM +0100, Peter Eisentraut wrote:
> There are a number of elog(LOG) calls that appear to be user-facing, so they
> should be ereport()s.
> @@ -8591,25 +8604,46 @@ LogCheckpointEnd(bool restartpoint)
> CheckpointStats.ckpt_sync_rels;
>
On Wed, Dec 02, 2020 at 11:04:45AM -0300, Alvaro Herrera wrote:
> Please take the opportunity to move the flag name out of the message in
> this one, also. I do wonder if it'd be a good idea to move the syscall
> name itself out of the message, too; that would reduce the number of
> messages to
On 2020-Dec-02, Peter Eisentraut wrote:
> There are a number of elog(LOG) calls that appear to be user-facing, so they
> should be ereport()s. This patch changes them. There are more elog(LOG)
> calls remaining, but they all appear to be some kind of debugging support.
> Also, I changed a few
specifically look for them.
From 05e5cf58e66072202707c6fddcd59768a26039be Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 2 Dec 2020 13:16:15 +0100
Subject: [PATCH] Convert elog(LOG) calls to ereport() where appropriate
User-visible log messages should go through ereport(), so
