On Wed, Aug 6, 2025 at 7:16 PM John Naylor wrote:
> > BTW, I see that you applied ed26c4e25 only to master, but don't
> > we want to back-patch? cpluspluscheck is not just an exercise in a
> > vacuum, it's to ensure that C++-coded extensions don't have trouble
> > with our headers.
>
> I was thin
John Naylor writes:
> On Wed, Aug 6, 2025 at 12:26 AM Tom Lane wrote:
>> BTW, I see that you applied ed26c4e25 only to master, but don't
>> we want to back-patch? cpluspluscheck is not just an exercise in a
>> vacuum, it's to ensure that C++-coded extensions don't have trouble
>> with our header
On Wed, Aug 6, 2025 at 12:26 AM Tom Lane wrote:
> diff --git a/src/include/utils/pg_locale.h b/src/include/utils/pg_locale.h
> index 931f5b3b880..2b072cafb4d 100644
> --- a/src/include/utils/pg_locale.h
> +++ b/src/include/utils/pg_locale.h
> @@ -18,6 +18,8 @@
> /* only include the C APIs, to av
John Naylor writes:
> On Mon, Jul 7, 2025 at 11:06 PM Tom Lane wrote:
>> John Naylor writes:
>>> I see that now. If extensions follow the practice of including system
>>> headers before Postgres headers, it should be fine. I've attached v2
>>> which removes the useless #undef and drafts an expla
On Mon, Jul 7, 2025 at 11:06 PM Tom Lane wrote:
>
> John Naylor writes:
> > I see that now. If extensions follow the practice of including system
> > headers before Postgres headers, it should be fine. I've attached v2
> > which removes the useless #undef and drafts an explanatory commit
> > mess
John Naylor writes:
> I see that now. If extensions follow the practice of including system
> headers before Postgres headers, it should be fine. I've attached v2
> which removes the useless #undef and drafts an explanatory commit
> message.
Works for me.
regards, tom lan
On Fri, Jul 4, 2025 at 10:11 PM Tom Lane wrote:
>
> Andres Freund writes:
> >> +/* restore so that extensions can include the C++ APIs */
> >> +#undef U_SHOW_CPLUSPLUS_API
>
> > Does the #undef U_SHOW_CPLUSPLUS_API thing actually work, given that ucol.h
> > presumably won't be included again due
Andres Freund writes:
> On 2025-07-02 14:01:13 +0700, John Naylor wrote:
>> I came up with the attached -- Andres, Peter, does this match your
>> recollection?
> I think the proper fix here would be to not expose ucol.h to the world,
> i.e. not include it from something like pg_locale.h.
The st
Hi,
On 2025-07-02 14:01:13 +0700, John Naylor wrote:
> On Tue, Jul 1, 2025 at 9:24 PM Tom Lane wrote:
> > Ha, indeed you are right. On my RHEL9 box, it's kinda drowned out
> > by complaints about
> >
> > /usr/include/c++/11/bits/range_access.h:109:3: error: template with C
> > linkage
> > 109
John Naylor writes:
> After pushing my fix, I looked into this, and CI works around this by
> disabling ICU. A proper fix was discussed here, but it trailed off:
> https://www.postgresql.org/message-id/flat/20230311033727.koa4saxy5wyquu6s%40awork3.anarazel.de#03346c63050bbc69dfca8981a5698e4a
> I c
On 02.07.25 09:01, John Naylor wrote:
On Tue, Jul 1, 2025 at 9:24 PM Tom Lane wrote:
Ha, indeed you are right. On my RHEL9 box, it's kinda drowned out
by complaints about
/usr/include/c++/11/bits/range_access.h:109:3: error: template with C linkage
109 | template _Tp* end(valarray<_Tp>&)
On Tue, Jul 1, 2025 at 9:24 PM Tom Lane wrote:
> Ha, indeed you are right. On my RHEL9 box, it's kinda drowned out
> by complaints about
>
> /usr/include/c++/11/bits/range_access.h:109:3: error: template with C linkage
> 109 | template _Tp* end(valarray<_Tp>&) noexcept;
> | ^~~~
>
12 matches
Mail list logo
