Re: create_help.pl treats as replaceable

On 19.05.22 04:12, Kyotaro Horiguchi wrote: At Wed, 18 May 2022 18:23:57 +0200, Peter Eisentraut wrote in "Boolean" is correct; see for example. Ok, so, don't we in turn need to replace "boolean"s with "Boolean"? "only boolean operators can have

Re: create_help.pl treats as replaceable

On 18.05.22 18:29, Tom Lane wrote: I think you should have upper-cased MATCH while at it, to make it clear that it acts like a keyword in this context. The current situation is quite unreadable in plain-ASCII output: regression=# \help copy Command: COPY ... HEADER [ boolean | match ]

Re: create_help.pl treats as replaceable

At Wed, 18 May 2022 18:23:57 +0200, Peter Eisentraut wrote in > "Boolean" is correct; see for > example. Ok, so, don't we in turn need to replace "boolean"s with "Boolean"? "only boolean operators can have negators" "only boolean operators can have

Re: create_help.pl treats as replaceable

Peter Eisentraut writes: > On 17.05.22 17:09, Tom Lane wrote: >> Isn't that a documentation bug rather than a problem with create_help? > Yeah, there is no need for a inside a . So I just > removed it. I think you should have upper-cased MATCH while at it, to make it clear that it acts like

Re: create_help.pl treats as replaceable

On 18.05.22 02:58, Kyotaro Horiguchi wrote: Oh, agreed. Thanks for the correction. By the way the error message in defGetCopyHeaderChoice is as follows. "%s requires a Boolean value or \"match\"" Should it be "%s requires a boolean value or MATCH"? The documentation of COPY currently appears

Re: create_help.pl treats as replaceable

On 17.05.22 17:09, Tom Lane wrote: By a quick look it seems to me that the "match" in "COPY.. HEADER match" is the first and only instance of a literal parameter as of PG15. Isn't that a documentation bug rather than a problem with create_help? Yeah, there is no need for a inside a . So I

Re: create_help.pl treats as replaceable

At Tue, 17 May 2022 11:09:23 -0400, Tom Lane wrote in > but that just seems flat-out wrong. If "match" is a keyword it should > be rendered like other keywords. I'm not very interested in splitting > hairs about whether the grammar thinks it is a keyword --- it looks like > one to a user. So

Re: create_help.pl treats as replaceable

Kyotaro Horiguchi writes: > I found it annoying that sql_help.c contains a literal parameter as a > translatable string. > The cause is that create_help.pl treats match as a > replaceable. The attached excludes literals from translatable strings. > By a quick look it seems to me that the

create_help.pl treats as replaceable

I found it annoying that sql_help.c contains a literal parameter as a translatable string. The cause is that create_help.pl treats match as a replaceable. The attached excludes literals from translatable strings. By a quick look it seems to me that the "match" in "COPY.. HEADER match" is the