Re: deadlock-hard flakiness

2023-02-08 Thread Andres Freund
Hi, On 2023-02-08 14:11:45 -0800, Andres Freund wrote: > On 2023-02-07 17:10:21 -0800, Andres Freund wrote: > I don't really understand how GetSafeSnapshotBlockingPids() can end up finding > deadlock-hard's sessions being blocked by a safe snapshot. Afaict nothing uses > serializable in that

Re: deadlock-hard flakiness

2023-02-08 Thread Andres Freund
Hi, On 2023-02-07 17:10:21 -0800, Andres Freund wrote: > diff -U3 /tmp/cirrus-ci-build/src/test/isolation/expected/deadlock-hard.out > /tmp/cirrus-ci-build/build/testrun/isolation-running/isolation/results/deadlock-hard.out > --- /tmp/cirrus-ci-build/src/test/isolation/expected/deadlock-hard.out

Re: deadlock-hard flakiness

2023-02-08 Thread Thomas Munro
On Wed, Feb 8, 2023 at 11:34 PM Thomas Munro wrote: > On Wed, Feb 8, 2023 at 2:10 PM Andres Freund wrote: > > I'm fairly sure I've seen this failure on the buildfarm as well, but I'm too > > impatient to wait for the buildfarm database query (it really should be > > updated to use lz4 toast

Re: deadlock-hard flakiness

2023-02-08 Thread Thomas Munro
On Wed, Feb 8, 2023 at 2:10 PM Andres Freund wrote: > I'm fairly sure I've seen this failure on the buildfarm as well, but I'm too > impatient to wait for the buildfarm database query (it really should be > updated to use lz4 toast compression). Failures in deadlock-hard (excluding crashes,

Re: deadlock-hard flakiness

2023-02-07 Thread Andres Freund
Hi, On 2023-02-07 17:10:21 -0800, Andres Freund wrote: > So far the diff always is: > > diff -U3 /tmp/cirrus-ci-build/src/test/isolation/expected/deadlock-hard.out > /tmp/cirrus-ci-build/build/testrun/isolation-running/isolation/results/deadlock-hard.out > ---

deadlock-hard flakiness

2023-02-07 Thread Andres Freund
Hi, On cfbot / CI, we've recently seen a lot of spurious test failures due to src/test/isolation/specs/deadlock-hard.spec changing output. Always on freebsd, when running tests against a pre-existing instance. I'm fairly sure I've seen this failure on the buildfarm as well, but I'm too impatient