Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-09-12 Thread Alexander Korotkov
On Thu, Sep 12, 2019 at 3:39 PM Euler Taveira wrote: > Em seg, 10 de jun de 2019 às 14:34, Alexander Korotkov > escreveu: > > > > Pushed! > > > Alexander, this commit is ok for 11 and so. However, GUC > strict_word_similarity_threshold does not exist in 9.6 and 10. The > attached patch revert

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-09-12 Thread Euler Taveira
Em seg, 10 de jun de 2019 às 14:34, Alexander Korotkov escreveu: > > Pushed! > Alexander, this commit is ok for 11 and so. However, GUC strict_word_similarity_threshold does not exist in 9.6 and 10. The attached patch revert this part. It should apply cleanly in 9.6 and 10. -- Euler Taveira

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-06-10 Thread Ian Barwick
On 6/11/19 2:33 AM, Alexander Korotkov wrote: On Sat, Jun 8, 2019 at 8:17 PM Alexander Korotkov wrote: On Fri, Jun 7, 2019 at 6:02 PM Ian Barwick wrote: On 6/7/19 9:00 PM, Michael Paquier wrote: On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote: > Or is that not worth

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-06-10 Thread Alexander Korotkov
On Sat, Jun 8, 2019 at 8:17 PM Alexander Korotkov wrote: > On Fri, Jun 7, 2019 at 6:02 PM Ian Barwick > wrote: > > On 6/7/19 9:00 PM, Michael Paquier wrote: > > > On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote: > > > Or is that not worth bothering except on HEAD? Thoughts? >

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-06-08 Thread Alexander Korotkov
On Fri, Jun 7, 2019 at 6:02 PM Ian Barwick wrote: > On 6/7/19 9:00 PM, Michael Paquier wrote: > > On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote: > > Or is that not worth bothering except on HEAD? Thoughts? > > Personally I don't think it's that critical, but not bothered

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-06-07 Thread Ian Barwick
On 6/7/19 9:00 PM, Michael Paquier wrote: On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote: BTW while looking GUC variables defined in trgm_op.c the operators in each short description seems not correct; there is an extra percent sign. Should we also fix them? Both of you are

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-06-07 Thread Michael Paquier
On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote: > BTW while looking GUC variables defined in trgm_op.c the operators in > each short description seems not correct; there is an extra percent > sign. Should we also fix them? Both of you are right here, and the addition

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-06-07 Thread Masahiko Sawada
On Thu, Jun 6, 2019 at 10:19 PM Ian Barwick wrote: > > Hi > > Commit be8a7a68662 added custom GUC > "pg_trgm.strict_word_similarity_threshold", > but omitted to document this in the section "GUC Parameters"; Indeed. BTW while looking GUC variables defined in trgm_op.c the operators in each

doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

2019-06-06 Thread Ian Barwick
Hi Commit be8a7a68662 added custom GUC "pg_trgm.strict_word_similarity_threshold", but omitted to document this in the section "GUC Parameters"; proposed patch attached. I suggest backpatching to Pg11, where it was introduced. Regards Ian Barwick -- Ian Barwick