Re: doc fix for pg_stat_activity.backend_type

2018-11-15 Thread John Naylor
On 11/15/18, Amit Kapila wrote: > Pushed, thanks for working on this. Thanks for your input. -John Naylor

Re: doc fix for pg_stat_activity.backend_type

2018-11-14 Thread Amit Kapila
On Tue, Nov 13, 2018 at 5:03 PM Amit Kapila wrote: > > On Tue, Nov 13, 2018 at 3:37 PM John Naylor wrote: > > > + In addition, extensions may have additional types. > > > > > > How about: "In addition, background workers registered by extensions > > > may have additional types."? > > > > Sou

Re: doc fix for pg_stat_activity.backend_type

2018-11-13 Thread John Naylor
On 11/13/18, Amit Kapila wrote: > On Tue, Nov 13, 2018 at 3:37 PM John Naylor wrote: >> >> On 11/13/18, Amit Kapila wrote: >> > >> > Don't you need to remove background worker? >> >> It's handled in pgstat_get_backend_desc(), so I assumed not. If that's >> just a place holder, then it's probably

Re: doc fix for pg_stat_activity.backend_type

2018-11-13 Thread Amit Kapila
On Tue, Nov 13, 2018 at 3:37 PM John Naylor wrote: > > On 11/13/18, Amit Kapila wrote: > > > > Don't you need to remove background worker? > > It's handled in pgstat_get_backend_desc(), so I assumed not. If that's > just a place holder, then it's probably better left out, as in the > attached. >

Re: doc fix for pg_stat_activity.backend_type

2018-11-13 Thread John Naylor
On 11/13/18, Amit Kapila wrote: > On Tue, Nov 13, 2018 at 12:04 PM John Naylor wrote: >> >> On 11/13/18, Amit Kapila wrote: >> > On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier >> > wrote: >> >> >> >> On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: >> >> > Looks like it. A quick se

Re: doc fix for pg_stat_activity.backend_type

2018-11-13 Thread Amit Kapila
On Tue, Nov 13, 2018 at 12:04 PM John Naylor wrote: > > On 11/13/18, Amit Kapila wrote: > > On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier > > wrote: > >> > >> On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: > >> > Looks like it. A quick search revealed "parallel worker" and "logic

Re: doc fix for pg_stat_activity.backend_type

2018-11-12 Thread John Naylor
On 11/13/18, Amit Kapila wrote: > On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier > wrote: >> >> On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: >> > Looks like it. A quick search revealed "parallel worker" and "logical >> > replication worker". src/test/modules/ also show "test_shm_

Re: doc fix for pg_stat_activity.backend_type

2018-11-12 Thread Amit Kapila
On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier wrote: > > On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: > > Looks like it. A quick search revealed "parallel worker" and "logical > > replication worker". src/test/modules/ also show "test_shm_mq" and > > "worker_spi", but it seems th

Re: doc fix for pg_stat_activity.backend_type

2018-11-12 Thread Michael Paquier
On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: > Looks like it. A quick search revealed "parallel worker" and "logical > replication worker". src/test/modules/ also show "test_shm_mq" and > "worker_spi", but it seems those don't need to be publicly documented. > If that sounds right I

Re: doc fix for pg_stat_activity.backend_type

2018-11-12 Thread John Naylor
On 11/12/18, Amit Kapila wrote: > On Mon, Nov 12, 2018 at 1:20 PM John Naylor wrote: >> >> Hi all, >> >> Commit fc70a4b0df3 added backend_type to pg_stat_activity, but the >> documentation omitted "logical replication launcher". Patch attached. >> > > Isn't this the fallout of commit 5373bc2a08 w

Re: doc fix for pg_stat_activity.backend_type

2018-11-12 Thread Amit Kapila
On Mon, Nov 12, 2018 at 1:20 PM John Naylor wrote: > > Hi all, > > Commit fc70a4b0df3 added backend_type to pg_stat_activity, but the > documentation omitted "logical replication launcher". Patch attached. > Isn't this the fallout of commit 5373bc2a08 which has added background worker types? If

doc fix for pg_stat_activity.backend_type

2018-11-11 Thread John Naylor
Hi all, Commit fc70a4b0df3 added backend_type to pg_stat_activity, but the documentation omitted "logical replication launcher". Patch attached. -John Naylor diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index add71458e2..ddf607bb17 100644 --- a/doc/src/sgml/monitoring.