Re: doc pg_constraint.convalidated column description need update

2025-06-09 Thread Robert Treat
On Mon, Jun 9, 2025 at 12:00 AM jian he wrote: > > On Thu, Jun 5, 2025 at 4:47 AM Robert Treat wrote: > > > > I think some of those changes are worth a second stab, so here is an > > updated patch which removes the ancillary tagging and corresponding > > line wrappings and focuses just on the wor

Re: doc pg_constraint.convalidated column description need update

2025-06-08 Thread jian he
On Thu, Jun 5, 2025 at 4:47 AM Robert Treat wrote: > > I think some of those changes are worth a second stab, so here is an > updated patch which removes the ancillary tagging and corresponding > line wrappings and focuses just on the wording/grammer improvements; > hopefully it will be easier to

Re: doc pg_constraint.convalidated column description need update

2025-06-04 Thread Robert Treat
On Wed, Jun 4, 2025 at 9:37 AM Peter Eisentraut wrote: > On 03.05.25 17:42, Robert Treat wrote: > > I actually think this mix of VALID / ENFORCED is a little convoluted > > for end users, but I don't think the system catalog documentation is > > the best place to work that out, and I see we've als

Re: doc pg_constraint.convalidated column description need update

2025-06-04 Thread Peter Eisentraut
On 03.05.25 17:42, Robert Treat wrote: I actually think this mix of VALID / ENFORCED is a little convoluted for end users, but I don't think the system catalog documentation is the best place to work that out, and I see we've also not added this type of extra information to other columns in the t

Re: doc pg_constraint.convalidated column description need update

2025-05-06 Thread Robert Treat
On Tue, May 6, 2025 at 4:49 AM jian he wrote: > > On Sat, May 3, 2025 at 11:42 PM Robert Treat wrote: > > As such, attached patch removes the above, and attempts some clean up > > of the documentation in ALTER TABLE to better clarify the behavior > > around valid/not valid, enforced/not enforced,

Re: doc pg_constraint.convalidated column description need update

2025-05-06 Thread jian he
On Sat, May 3, 2025 at 11:42 PM Robert Treat wrote: > As such, attached patch removes the above, and attempts some clean up > of the documentation in ALTER TABLE to better clarify the behavior > around valid/not valid, enforced/not enforced, and how it affects > different constraints, with some ad

Re: doc pg_constraint.convalidated column description need update

2025-05-03 Thread Robert Treat
On Thu, May 1, 2025 at 10:19 PM jian he wrote: > > hi. > > catalog.sgml: > > > >convalidated bool > > >Has the constraint been validated? >Currently, can be false only for foreign keys and CHECK constraints > > > > with NOT NULL NOT V

doc pg_constraint.convalidated column description need update

2025-05-01 Thread jian he
hi. catalog.sgml: convalidated bool Has the constraint been validated? Currently, can be false only for foreign keys and CHECK constraints with NOT NULL NOT VALID, we need rephrase it to something like: "Currently, can be false only fo