Re: docs: pg_replication_origin_oid() description does not match behaviour

2022-01-18 Thread Ian Lawrence Barwick
2022年1月19日(水) 10:40 Michael Paquier : > > On Tue, Jan 18, 2022 at 06:20:22PM +, Bossart, Nathan wrote: > > +1 > > And done. Thanks! Ian Barwick -- EnterpriseDB: https://www.enterprisedb.com

Re: docs: pg_replication_origin_oid() description does not match behaviour

2022-01-18 Thread Michael Paquier
On Tue, Jan 18, 2022 at 06:20:22PM +, Bossart, Nathan wrote: > +1 And done. -- Michael signature.asc Description: PGP signature

Re: docs: pg_replication_origin_oid() description does not match behaviour

2022-01-18 Thread Bossart, Nathan
On 1/17/22, 5:24 PM, "Michael Paquier" wrote: > On Tue, Jan 18, 2022 at 10:19:41AM +0900, Ian Lawrence Barwick wrote: >> Given that the code has remained unchanged since the function was >> introduced in 9.5, it seems reasonable to change the documentation >> to match the function behaviour rather

Re: docs: pg_replication_origin_oid() description does not match behaviour

2022-01-17 Thread Michael Paquier
On Tue, Jan 18, 2022 at 10:19:41AM +0900, Ian Lawrence Barwick wrote: > Given that the code has remained unchanged since the function was > introduced in 9.5, it seems reasonable to change the documentation > to match the function behaviour rather than the other way round. Obviously. I'll go fix

docs: pg_replication_origin_oid() description does not match behaviour

2022-01-17 Thread Ian Lawrence Barwick
Hi >From the documentation for pg_replication_origin_oid() [1]: > Looks up a replication origin by name and returns the internal ID. > If no such replication origin is found an error is thrown. However, it actually returns NULL if the origin does not exist: postgres=# SELECT * FROM pg_repli