Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2022-01-11 Thread Fujii Masao
On 2022/01/08 1:50, Bharath Rupireddy wrote: PSA v7 patch. Thanks for updating the patch! I applied some cosmetic changes and pushed the patch. Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2022-01-07 Thread Bharath Rupireddy
On Fri, Jan 7, 2022 at 9:19 PM Fujii Masao wrote: > > On 2021/11/29 11:44, vignesh C wrote: > > Thanks for the updated patch. The patch applies neatly, make > > check-world passes and the documentation looks good. I did not find > > any issues with the v6 patch, I'm marking the patch as Ready

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2022-01-07 Thread Fujii Masao
On 2021/11/29 11:44, vignesh C wrote: Thanks for the updated patch. The patch applies neatly, make check-world passes and the documentation looks good. I did not find any issues with the v6 patch, I'm marking the patch as Ready for Committer. I started reading the patch. +CREATE FUNCTION

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-28 Thread vignesh C
On Sun, Nov 28, 2021 at 7:15 PM Bharath Rupireddy wrote: > > On Sun, Nov 28, 2021 at 5:21 PM vignesh C wrote: > > Thanks for the updated patch, one comment: > > 1) The function can be indented similar to other functions in the same > > file: > > +CREATE FUNCTION memcxt_get_proc_pid(text) > >

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-28 Thread Bharath Rupireddy
On Sun, Nov 28, 2021 at 5:21 PM vignesh C wrote: > Thanks for the updated patch, one comment: > 1) The function can be indented similar to other functions in the same file: > +CREATE FUNCTION memcxt_get_proc_pid(text) > +RETURNS int > +LANGUAGE SQL > +AS 'SELECT pid FROM pg_stat_activity WHERE

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-28 Thread vignesh C
On Sun, Nov 28, 2021 at 12:25 PM Bharath Rupireddy wrote: > > On Sun, Nov 28, 2021 at 12:22 PM vignesh C wrote: > > > Attaching v4 patch, please review it further. > > > > One small comment: > > 1) There should be a space in between "LOGmessage level" > > +it can) for memory contexts.

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-27 Thread Bharath Rupireddy
On Sun, Nov 28, 2021 at 12:22 PM vignesh C wrote: > > Attaching v4 patch, please review it further. > > One small comment: > 1) There should be a space in between "LOGmessage level" > +it can) for memory contexts. These memory contexts will be logged at > +LOGmessage level. They

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-27 Thread vignesh C
On Mon, Nov 15, 2021 at 10:27 PM Bharath Rupireddy wrote: > > On Mon, Nov 15, 2021 at 10:04 PM vignesh C wrote: > > > > On Mon, Nov 15, 2021 at 7:47 AM Bharath Rupireddy > > wrote: > > > > > > On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy > > > wrote: > > > > PSA v2 patch and review it. >

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-15 Thread Bharath Rupireddy
On Mon, Nov 15, 2021 at 10:04 PM vignesh C wrote: > > On Mon, Nov 15, 2021 at 7:47 AM Bharath Rupireddy > wrote: > > > > On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy > > wrote: > > > PSA v2 patch and review it. > > > > I've modified the docs part a bit, please consider v3 for review. > >

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-15 Thread vignesh C
On Mon, Nov 15, 2021 at 7:47 AM Bharath Rupireddy wrote: > > On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy > wrote: > > PSA v2 patch and review it. > > I've modified the docs part a bit, please consider v3 for review. Thanks for the update patch, Few comments: 1) Should we change

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-14 Thread Bharath Rupireddy
On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy wrote: > PSA v2 patch and review it. I've modified the docs part a bit, please consider v3 for review. Regards, Bharath Rupireddy. v3-0001-enhance-pg_log_backend_memory_contexts-to-log-mem.patch Description: Binary data

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-04 Thread Bharath Rupireddy
On Thu, Nov 4, 2021 at 9:35 AM Bharath Rupireddy wrote: > > I think the reason we need to do this is not that aux processes have > > the invalid backend id (=InvalidBackendId) but that "some" auxiliary > > processes may have a broken proc->backendId in regard to > > SendProcSignal (we know that's

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-11-03 Thread Bharath Rupireddy
On Mon, Nov 1, 2021 at 6:42 AM Kyotaro Horiguchi wrote: > > At Fri, 29 Oct 2021 22:25:04 +0530, Bharath Rupireddy > wrote in > > On Mon, Oct 11, 2021 at 9:55 AM Bharath Rupireddy > > wrote: > > > > > > On Mon, Oct 11, 2021 at 8:21 AM torikoshia > > > wrote: > > > > If we can use debuggers,

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-10-31 Thread Kyotaro Horiguchi
At Fri, 29 Oct 2021 22:25:04 +0530, Bharath Rupireddy wrote in > On Mon, Oct 11, 2021 at 9:55 AM Bharath Rupireddy > wrote: > > > > On Mon, Oct 11, 2021 at 8:21 AM torikoshia > > wrote: > > > If we can use debuggers, it's possible to know the memory contexts e.g. > > > using

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-10-29 Thread Bharath Rupireddy
On Mon, Oct 11, 2021 at 9:55 AM Bharath Rupireddy wrote: > > On Mon, Oct 11, 2021 at 8:21 AM torikoshia wrote: > > > > Thanks for working on this! > > > > On 2021-10-09 22:23, Bharath Rupireddy wrote: > > > Hi, > > > > > > Currently pg_log_backend_memory_contexts() doesn't log the memory > > >

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-10-10 Thread Bharath Rupireddy
On Mon, Oct 11, 2021 at 8:21 AM torikoshia wrote: > > Thanks for working on this! > > On 2021-10-09 22:23, Bharath Rupireddy wrote: > > Hi, > > > > Currently pg_log_backend_memory_contexts() doesn't log the memory > > contexts of auxiliary processes such as bgwriter, checkpointer, wal > > writer,

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-10-10 Thread torikoshia
Thanks for working on this! On 2021-10-09 22:23, Bharath Rupireddy wrote: Hi, Currently pg_log_backend_memory_contexts() doesn't log the memory contexts of auxiliary processes such as bgwriter, checkpointer, wal writer, archiver, startup process and wal receiver. It will be useful to look at

enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

2021-10-09 Thread Bharath Rupireddy
Hi, Currently pg_log_backend_memory_contexts() doesn't log the memory contexts of auxiliary processes such as bgwriter, checkpointer, wal writer, archiver, startup process and wal receiver. It will be useful to look at the memory contexts of these processes too, for debugging purposes and better