Re: fill_extraUpdatedCols is done in completely the wrong place

2020-05-18 Thread Tom Lane
Peter Eisentraut writes: > On 2020-05-08 21:05, Tom Lane wrote: >> I happened to notice $subject while working on the release notes. >> AFAICS, it is 100% inappropriate for the parser to compute the >> set of generated columns affected by an UPDATE, because that set >> could change before executio

Re: fill_extraUpdatedCols is done in completely the wrong place

2020-05-18 Thread Peter Eisentraut
On 2020-05-08 21:05, Tom Lane wrote: I happened to notice $subject while working on the release notes. AFAICS, it is 100% inappropriate for the parser to compute the set of generated columns affected by an UPDATE, because that set could change before execution. It would be really easy to break t

fill_extraUpdatedCols is done in completely the wrong place

2020-05-08 Thread Tom Lane
I happened to notice $subject while working on the release notes. AFAICS, it is 100% inappropriate for the parser to compute the set of generated columns affected by an UPDATE, because that set could change before execution. It would be really easy to break this for an UPDATE in a stored rule, for