Re: future of serial and identity columns

2022-10-12 Thread Alvaro Herrera
On 2022-Oct-11, Peter Eisentraut wrote: > diff --git a/src/test/modules/test_ddl_deparse/expected/alter_table.out > b/src/test/modules/test_ddl_deparse/expected/alter_table.out > index 87a1ab7aabce..30e3dbb8d08a 100644 > --- a/src/test/modules/test_ddl_deparse/expected/alter_table.out > +++

Re: future of serial and identity columns

2022-10-12 Thread Peter Eisentraut
On 12.10.22 08:22, Corey Huinker wrote: Question: the xref  refers the reader to sql-createtable, which is a pretty big page, which could leave the reader lost. Would it make sense to create a SQL-CREATETABLE-IDENTITY anchor and link to that instead? Yes, I think that would be good.

Re: future of serial and identity columns

2022-10-12 Thread Corey Huinker
> > The feedback was pretty positive, so I dug through all the tests to at > least get to the point where I could see the end of it. The attached > patch 0001 is the actual code and documentation changes. The 0002 patch > is just tests randomly updated or disabled to make the whole suite pass. >

Re: future of serial and identity columns

2022-10-11 Thread Peter Eisentraut
On 04.10.22 09:41, Peter Eisentraut wrote: Attached is a demo patch how the implementation of this change would look like.  This creates a bunch of regression test failures, but AFAICT, those are mainly display differences and some very peculiar test setups that are intentionally examining

Re: future of serial and identity columns

2022-10-07 Thread Magnus Hagander
On Fri, Oct 7, 2022 at 2:03 PM Vik Fearing wrote: > On 10/4/22 09:41, Peter Eisentraut wrote: > > In PostgreSQL 10, we added identity columns, as an alternative to serial > > columns (since 6.something). They mostly work the same. Identity > > columns are SQL-conforming, have some more

Re: future of serial and identity columns

2022-10-07 Thread Vik Fearing
On 10/4/22 09:41, Peter Eisentraut wrote: In PostgreSQL 10, we added identity columns, as an alternative to serial columns (since 6.something).  They mostly work the same.  Identity columns are SQL-conforming, have some more features (e.g., overriding clause), and are a bit more robust in

Re: future of serial and identity columns

2022-10-05 Thread Bruce Momjian
On Tue, Oct 4, 2022 at 09:41:19AM +0200, Peter Eisentraut wrote: > In PostgreSQL 10, we added identity columns, as an alternative to serial > columns (since 6.something). They mostly work the same. Identity columns > are SQL-conforming, have some more features (e.g., overriding clause), and >

Re: future of serial and identity columns

2022-10-04 Thread Laurenz Albe
On Tue, 2022-10-04 at 09:41 +0200, Peter Eisentraut wrote: > In PostgreSQL 10, we added identity columns, as an alternative to serial > columns (since 6.something).  They mostly work the same.  Identity > columns are SQL-conforming, have some more features (e.g., overriding > clause), and are a

future of serial and identity columns

2022-10-04 Thread Peter Eisentraut
In PostgreSQL 10, we added identity columns, as an alternative to serial columns (since 6.something). They mostly work the same. Identity columns are SQL-conforming, have some more features (e.g., overriding clause), and are a bit more robust in schema management. Some of that was described