Chao Li writes:
> On Wed, Nov 19, 2025 at 4:33 PM Peter Eisentraut
> wrote:
>
>> I find the data structures that you have constructed here barely
>> understandable:
>>
>> my %required_by_type = (
>> int => [qw(min max)],
>> real => [qw(min max)],
>> enum => [qw(o
On Wed, Nov 19, 2025 at 4:33 PM Peter Eisentraut
wrote:
> I find the data structures that you have constructed here barely
> understandable:
>
> my %required_by_type = (
> int => [qw(min max)],
> real => [qw(min max)],
> enum => [qw(options)],
> );
>
> f
I find the data structures that you have constructed here barely
understandable:
my %required_by_type = (
int => [qw(min max)],
real => [qw(min max)],
enum => [qw(options)],
);
for my $f (@required_common, @{ $required_by_type{$entry->{type} //
''} // [] })
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
I tested patch v2 on top of current master.
- The patch applies cleanly.
- F
Added to CF: https://commitfest.postgresql.org/patch/6226/
> On Nov 12, 2025, at 09:10, Chao Li wrote:
>
>
>
> On Mon, Nov 10, 2025 at 8:02 PM Dagfinn Ilmari Mannsåker
> wrote:
> Chao Li writes:
>
> > Hi Hacker,
> >
> > While working on the other patch and editing guc_parameters.dat, I
> >
On Mon, Nov 10, 2025 at 8:02 PM Dagfinn Ilmari Mannsåker
wrote:
> Chao Li writes:
>
> > Hi Hacker,
> >
> > While working on the other patch and editing guc_parameters.dat, I
> > mistakenly deleted a “max” value line, then I got the following error
> > during build:
> >
> > ```
> > '/opt/homebrew
On 2025-Nov-10, Chao Li wrote:
> While working on the other patch and editing guc_parameters.dat, I
> mistakenly deleted a “max” value line, then I got the following error
> during build:
> The error message is unclear and is not helpful to identify the real issue.
Funny -- I made a very similar
Chao Li writes:
> Hi Hacker,
>
> While working on the other patch and editing guc_parameters.dat, I
> mistakenly deleted a “max” value line, then I got the following error
> during build:
>
> ```
> '/opt/homebrew/bin/perl' ../../../src/backend/utils/misc/gen_guc_tables.pl
> ../../../src/backend/u
Hi Hacker,
While working on the other patch and editing guc_parameters.dat, I
mistakenly deleted a “max” value line, then I got the following error
during build:
```
'/opt/homebrew/bin/perl' ../../../src/backend/utils/misc/gen_guc_tables.pl
../../../src/backend/utils/misc/guc_parameters.dat guc_t
