Hi,
On 2025-08-07 10:58:56 -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > kwlist_d.h doesn't show up in my run, probably because I'm using a
> > separate build directory, which headerscheck doesn't handle? Another
> > thing to fix.
>
> Yeah, as it stands headerscheck is really only meant
Peter Eisentraut writes:
> Attached are three patches to fix some unrelated problems with
> headerscheck in my environment.
0001 seems fine; it's an oversight that I'd not noticed because
ICU_CFLAGS is empty in my usage.
Don't like 0002 as-is. I'd be okay with skipping that header if
--with-ll
On 06.08.25 21:11, Tom Lane wrote:
Peter Eisentraut writes:
On 05.08.25 20:09, Tom Lane wrote:
Curiously, no such complaints appear with cpluspluscheck (which is
using g++ 15.1.1). I don't really understand why not ...
-Wmissing-variable-declarations is added by us as of PG18 (commit
66188
Peter Eisentraut writes:
> On 05.08.25 20:09, Tom Lane wrote:
>> Curiously, no such complaints appear with cpluspluscheck (which is
>> using g++ 15.1.1). I don't really understand why not ...
> -Wmissing-variable-declarations is added by us as of PG18 (commit
> 66188912566). It's available sin
On 05.08.25 20:09, Tom Lane wrote:
Curiously, no such complaints appear with cpluspluscheck (which is
using g++ 15.1.1). I don't really understand why not: why would
they have turned on -Wmissing-variable-declarations by default
for C but not C++? But anyway, since there doesn't seem to be
any
Using gcc 15.1.1 (from Fedora 42) I see these warnings that
didn't appear with older gcc:
$ src/tools/pginclude/headerscheck
In file included from /tmp/headerscheck.xp0AI5/test.c:2:
./src/common/kwlist_d.h:1163:23: warning: no previous declaration for
'ScanKeywords' [-Wmissing-variable-declaratio
