Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Andrew Gierth
> "Peter" == Peter Geoghegan writes: Peter> There are a couple of other odd things that look related, such Peter> as this extract from the triggers.out section of my Peter> regression.diffs: That one is pretty obvious (from RelationBuildTriggers): * Note: since we scan the triggers

Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Peter Geoghegan
On Thu, May 3, 2018 at 7:26 PM, Alvaro Herrera wrote: > I bet this is related to how are these objects reached while walking the > dependency graph -- i.e. they are reached first as columns and reported > explicitly in the second case, but in the first case the tables are > reached first so the co

Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Peter Geoghegan
On Thu, May 3, 2018 at 7:31 PM, Tom Lane wrote: > Ah, I think it's just an order-of-visitation issue then. There are > dependencies at both the column and whole-table level, specifically > > schema collate_tests -> table collate_test4 > schema collate_tests -> domain testdomain_p -> column collat

Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Tom Lane
Peter Geoghegan writes: > In the case of the collate tests, these are the 17 objects I can see > with ignore_system_indexes=off, once I remove the "\set VERBOSITY > terse" line from the end of collate.sql: > ... > drop cascades to table collate_test23 > drop cascades to table collate_test4 > drop

Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Alvaro Herrera
Peter Geoghegan wrote: > In the case of ignore_system_indexes=on, I see the same 17 entries, in > addition to these 3 (20 total): > > drop cascades to table collate_test23 column f1 > drop cascades to table collate_test4 column b > drop cascades to table collate_test5 column b > > Perhaps this m

Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Peter Geoghegan
On Thu, May 3, 2018 at 4:14 PM, Peter Geoghegan wrote: > On Thu, May 3, 2018 at 3:18 PM, Tom Lane wrote: >> Indeed, that seems weird. Maybe tweak the test scripts so you can see >> all the objects cascaded to, and then find out what the additional >> object is? (I think also you could look into

Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Peter Geoghegan
On Thu, May 3, 2018 at 3:18 PM, Tom Lane wrote: > Peter Geoghegan writes: >> Why should the drop cascade to 63 objects rather than 62 because I've >> set ignore_system_indexes=on? > > Indeed, that seems weird. Maybe tweak the test scripts so you can see > all the objects cascaded to, and then fi

Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Tom Lane
Peter Geoghegan writes: > Why should the drop cascade to 63 objects rather than 62 because I've > set ignore_system_indexes=on? Indeed, that seems weird. Maybe tweak the test scripts so you can see all the objects cascaded to, and then find out what the additional object is? (I think also you c

ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped

2018-05-03 Thread Peter Geoghegan
Setting ignore_system_indexes=off in postgresql.conf has the effect of making almost all regression tests fail during a "make installcheck". This is unsurprising, since warnings are emitted all over the place. However, some of the specific ways in which it fails *are* surprising. I see the followi