Re: improve ssl error code, 2147483650

2024-03-07 Thread Tom Lane
Daniel Gustafsson writes: > On 7 Mar 2024, at 20:58, Tom Lane wrote: >> This could probably do with a comment, and we need to propagate >> the fix into libpq's copy of the function too. Barring objections, >> I'll take care of that and push it later today. > LGTM. Done so far as

Re: improve ssl error code, 2147483650

2024-03-07 Thread Daniel Gustafsson
> On 7 Mar 2024, at 20:58, Tom Lane wrote: > > I wrote: >> Stephen Frost writes: >>> Agreed that it doesn't seem well documented. I was trying to figure out >>> what the 'right' answer here was myself and not having much success. If >>> the above works, then +1 to that. > >> My reaction as

Re: improve ssl error code, 2147483650

2024-03-07 Thread Tom Lane
I wrote: > Stephen Frost writes: >> Agreed that it doesn't seem well documented. I was trying to figure out >> what the 'right' answer here was myself and not having much success. If >> the above works, then +1 to that. > My reaction as well --- I was just gearing up to test this idea, >

Re: improve ssl error code, 2147483650

2024-03-07 Thread Tom Lane
David Zhang writes: > When configuring SSL on the Postgres server side with the following > information: > ssl = on > ssl_ca_file = 'root_ca.crt' > ssl_cert_file = 'server-cn-only.crt' > ssl_key_file = 'server-cn-only.key' > If a user makes a mistake, for example, accidentally using

Re: improve ssl error code, 2147483650

2024-03-07 Thread Tom Lane
Stephen Frost writes: > * Heikki Linnakangas (hlinn...@iki.fi) wrote: >> That's pretty unfortunate. As typical with OpenSSL, this stuff is not very >> well documented, but I think we could do something like this in >> SSLerrmessage(): >> >> if (ERR_SYSTEM_ERROR(e)) >> errreason =

Re: improve ssl error code, 2147483650

2024-03-07 Thread Stephen Frost
Greetings, * Heikki Linnakangas (hlinn...@iki.fi) wrote: > On 07/03/2024 02:12, David Zhang wrote: > > The SSL_CTX_load_verify_locations function in OpenSSL will return NULL > > if there is a system error, such as "No such file or directory" in this > > case: > > > > const char

Re: improve ssl error code, 2147483650

2024-03-07 Thread Heikki Linnakangas
On 07/03/2024 02:12, David Zhang wrote: The SSL_CTX_load_verify_locations function in OpenSSL will return NULL if there is a system error, such as "No such file or directory" in this case: const char *ERR_reason_error_string(unsigned long e) {     ERR_STRING_DATA d, *p = NULL;     unsigned

improve ssl error code, 2147483650

2024-03-06 Thread David Zhang
Hi Hackers, When configuring SSL on the Postgres server side with the following information: ssl = on ssl_ca_file = 'root_ca.crt' ssl_cert_file = 'server-cn-only.crt' ssl_key_file = 'server-cn-only.key' If a user makes a mistake, for example, accidentally using 'root_ca.crl' instead of