Re: jsonb subscripting assignment performance

2021-04-14 Thread Alexander Korotkov
On Wed, Apr 14, 2021 at 10:57 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > sure - there is big room for optimization. But this patch was big enough > > without its optimization. And it was not clean, if I will be committed or > > not (it waited in commitfest application for 4 years). So I

Re: jsonb subscripting assignment performance

2021-04-14 Thread Joel Jacobson
On Wed, Apr 14, 2021, at 11:07, Oleg Bartunov wrote: > I and Nikita are working on OLTP jsonb > http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfonline-2021.pdf > Page 49/55 in the PDF: "UPDATE test_toast SET jb = jsonb_set(jb, {keyN,0}, ?);" Would you get similar improvements if

Re: jsonb subscripting assignment performance

2021-04-14 Thread Pavel Stehule
st 14. 4. 2021 v 11:07 odesílatel Oleg Bartunov napsal: > > > On Wed, Apr 14, 2021 at 11:09 AM Pavel Stehule > wrote: > >> >> >> st 14. 4. 2021 v 9:57 odesílatel Dmitry Dolgov <9erthali...@gmail.com> >> napsal: >> >>> > On Wed, Apr 14, 2021 at 09:20:08AM +0200, Pavel Stehule wrote: >>> > st 14.

Re: jsonb subscripting assignment performance

2021-04-14 Thread Oleg Bartunov
On Wed, Apr 14, 2021 at 11:09 AM Pavel Stehule wrote: > > > st 14. 4. 2021 v 9:57 odesílatel Dmitry Dolgov <9erthali...@gmail.com> > napsal: > >> > On Wed, Apr 14, 2021 at 09:20:08AM +0200, Pavel Stehule wrote: >> > st 14. 4. 2021 v 7:39 odesílatel Joel Jacobson >> napsal: >> > >> > > Hi, >> >

Re: jsonb subscripting assignment performance

2021-04-14 Thread Pavel Stehule
st 14. 4. 2021 v 9:57 odesílatel Dmitry Dolgov <9erthali...@gmail.com> napsal: > > On Wed, Apr 14, 2021 at 09:20:08AM +0200, Pavel Stehule wrote: > > st 14. 4. 2021 v 7:39 odesílatel Joel Jacobson > napsal: > > > > > Hi, > > > > > > commit 676887a3 added support for jsonb subscripting. > > > > >

Re: jsonb subscripting assignment performance

2021-04-14 Thread Dmitry Dolgov
> On Wed, Apr 14, 2021 at 09:20:08AM +0200, Pavel Stehule wrote: > st 14. 4. 2021 v 7:39 odesílatel Joel Jacobson napsal: > > > Hi, > > > > commit 676887a3 added support for jsonb subscripting. > > > > Many thanks for working on this. I really like the improved syntax. > > > > I was also hoping

Re: jsonb subscripting assignment performance

2021-04-14 Thread Joel Jacobson
On Wed, Apr 14, 2021, at 09:20, Pavel Stehule wrote: > sure - there is big room for optimization. But this patch was big enough > without its optimization. And it was not clean, if I will be committed or not > (it waited in commitfest application for 4 years). So I accepted implemented >

Re: jsonb subscripting assignment performance

2021-04-14 Thread Pavel Stehule
st 14. 4. 2021 v 7:39 odesílatel Joel Jacobson napsal: > Hi, > > commit 676887a3 added support for jsonb subscripting. > > Many thanks for working on this. I really like the improved syntax. > > I was also hoping for some performance benefits, > but my testing shows that > >

jsonb subscripting assignment performance

2021-04-13 Thread Joel Jacobson
Hi, commit 676887a3 added support for jsonb subscripting. Many thanks for working on this. I really like the improved syntax. I was also hoping for some performance benefits, but my testing shows that jsonb_value['existing_key'] = new_value; takes just as long time as jsonb_value :=