Re: libpq fails to build with TSAN

2024-01-31 Thread Daniel Gustafsson
> On 31 Jan 2024, at 16:39, Tom Lane wrote: > > Daniel Gustafsson writes: >> I think it should, the idea of that check is to catch calls to actual exits, >> while this is instrumentation which has nothing to do with exit(2). The >> attached diff should be enough to handle this. > > +1 Pushed.

Re: libpq fails to build with TSAN

2024-01-31 Thread Tom Lane
Daniel Gustafsson writes: > I think it should, the idea of that check is to catch calls to actual exits, > while this is instrumentation which has nothing to do with exit(2). The > attached diff should be enough to handle this. +1 regards, tom lane

Re: libpq fails to build with TSAN

2024-01-31 Thread Daniel Gustafsson
> On 31 Jan 2024, at 04:21, Roman Lozko wrote: > > Hi, so libpq has this line in its Makefile > https://github.com/postgres/postgres/blob/6ee26c6a4bafabbd22a85f575d2446fd5ec6ad0d/src/interfaces/libpq/Makefile#L116 > which checks that libpq does not use any "exit" functions. With > ThreadSanitizer

libpq fails to build with TSAN

2024-01-31 Thread Roman Lozko
Hi, so libpq has this line in its Makefile https://github.com/postgres/postgres/blob/6ee26c6a4bafabbd22a85f575d2446fd5ec6ad0d/src/interfaces/libpq/Makefile#L116 which checks that libpq does not use any "exit" functions. With ThreadSanitizer it triggers on function `__tsan_func_exit` which is used t