Re: libpq_pipeline in tmp_install

2021-05-25 Thread Peter Eisentraut
On 19.05.21 19:35, Tom Lane wrote: Alvaro Herrera writes: On 2021-May-19, Tom Lane wrote: +1, except that you should add documentation for NO_INSTALL to the list of definable symbols at the head of pgxs.mk, and to the list in extend.sgml (compare that for NO_INSTALLCHECK). I propose this.

Re: libpq_pipeline in tmp_install

2021-05-19 Thread Tom Lane
Alvaro Herrera writes: > On 2021-May-19, Tom Lane wrote: >> +1, except that you should add documentation for NO_INSTALL to the >> list of definable symbols at the head of pgxs.mk, and to the list >> in extend.sgml (compare that for NO_INSTALLCHECK). > I propose this. WFM.

Re: libpq_pipeline in tmp_install

2021-05-19 Thread Alvaro Herrera
On 2021-May-19, Tom Lane wrote: > Peter Eisentraut writes: > > On 10.05.21 20:26, Peter Eisentraut wrote: > >> The reason this is there is that the test suite uses PGXS to build the > >> test program, and so things get installed automatically.  I suggest that > >> we should either write out the

Re: libpq_pipeline in tmp_install

2021-05-19 Thread Tom Lane
Peter Eisentraut writes: > On 10.05.21 20:26, Peter Eisentraut wrote: >> The reason this is there is that the test suite uses PGXS to build the >> test program, and so things get installed automatically.  I suggest that >> we should either write out the build system by hand to avoid this, or >>

Re: libpq_pipeline in tmp_install

2021-05-19 Thread Peter Eisentraut
On 10.05.21 20:26, Peter Eisentraut wrote: The test program libpq_pipeline produced by the test suite in src/test/modules/libpq_pipeline/ is installed into tmp_install as part of make check.  This isn't a real problem by itself, but I think it creates a bit of an asymmetric situation that might

libpq_pipeline in tmp_install

2021-05-10 Thread Peter Eisentraut
The test program libpq_pipeline produced by the test suite in src/test/modules/libpq_pipeline/ is installed into tmp_install as part of make check. This isn't a real problem by itself, but I think it creates a bit of an asymmetric situation that might be worth cleaning up. Before, the content