On 27.08.23 14:05, Zhijie Hou (Fujitsu) wrote:
On Friday, August 25, 2023 5:56 PM Amit Kapila wrote:
On Fri, Aug 25, 2023 at 12:38 PM Peter Eisentraut wrote:
On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote:
On Friday, August 25, 2023 12:28 PM Amit Kapila
wrote:
On Thu, Aug 24, 2023 at 12
On Tuesday, August 29, 2023 3:26 PM Peter Smith wrote:
Thanks for reviewing.
> 2. DebugLogicalRepStreamingMode
>
> -/* possible values for logical_replication_mode */
> +/* possible values for debug_logical_replication_streaming */
> typedef enum
> {
> - LOGI
On Tue, Aug 29, 2023 at 12:56 PM Peter Smith wrote:
>
> I had a look at the patch 0001.
>
> It looks OK to me, but here are a couple of comments:
>
> ==
>
> 1. Is this fix intended for PG16?
>
Yes.
> I found some mention of this GUC old name lurking in the release v16 notes
> [1].
>
That s
logical_replication_mode */
+/* possible values for debug_logical_replication_streaming */
typedef enum
{
- LOGICAL_REP_MODE_BUFFERED,
- LOGICAL_REP_MODE_IMMEDIATE
-} LogicalRepMode;
+ DEBUG_LOGICAL_REP_STREAMING_BUFFERED,
+ DEBUG_LOGICAL_REP_STREAMING_IMMEDIATE
+} DebugLogicalRepStreamingMode;
Shouldn&#
r serialization of changes in
> > > large transactions." which is similar to the description in document.
> > >
> > > I agree that renaming it to debug_xx would be better and here is a
> > > patch that tries to do this.
> >
> > Maybe debug_logical_replication is too general? Something like
> > debug_logical_replication_streaming would be more concrete.
> >
>
> Yeah, that sounds better.
OK, here is the debug_logical_replication_streaming version.
Best Regards,
Hou zj
0001-Rename-logical_replication_mode-to-debug_logical_rep.patch
Description: 0001-Rename-logical_replication_mode-to-debug_logical_rep.patch
On Fri, Aug 25, 2023 at 12:38 PM Peter Eisentraut wrote:
>
> On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote:
> > On Friday, August 25, 2023 12:28 PM Amit Kapila
> > wrote:
> >>
> >> On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut
> >> wrote:
> >>>
> >>> I suggest we rename this setting to some
On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote:
On Friday, August 25, 2023 12:28 PM Amit Kapila wrote:
On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut
wrote:
I suggest we rename this setting to something starting with debug_.
Right now, the name looks much too tempting for users to fiddle
mediate streaming or serialization of changes in large
transactions." which is similar to the description in document.
I agree that renaming it to debug_xx would be better and
here is a patch that tries to do this.
Best Regards,
Hou zj
0001-Rename-logical_replication_mode-to-debug_logical_rep.patch
Description: 0001-Rename-logical_replication_mode-to-debug_logical_rep.patch
On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut wrote:
>
> I suggest we rename this setting to something starting with debug_.
> Right now, the name looks much too tempting for users to fiddle with. I
> think this is similar to force_parallel_mode.
>
+1. How about debug_logical_replication?
>
I suggest we rename this setting to something starting with debug_.
Right now, the name looks much too tempting for users to fiddle with. I
think this is similar to force_parallel_mode.
Also, the descriptions in guc_tables.c could be improved. For example,
gettext_noop("Controls when to
10 matches
Mail list logo
