On 2020-Mar-06, Ibrar Ahmed wrote:
> I think we need a tab-completion patch too for this.
Thanks, I pushed this.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
I pushed this (to pg13 only) using the originally proposed "NO DEPENDS"
syntax. It's trivial to change to REVOKE DEPENDS on REMOVE DEPENDS if
we decide to do that.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
As promised, here's a rebased version of this patch -- edits pending per
discussion to decide the grammar to use.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From 5df1613901906cff4d0b0b7e480691b65d9d2e5c Mon
On 2020-Mar-11, Tom Lane wrote:
> BTW, I did not like the syntax too much. "NO DEPENDS ON EXTENSION"
> doesn't seem like good English. "NOT DEPENDS ON EXTENSION" is hardly
> any better. The real problem with both is that an ALTER action should
> be, well, an action. A grammar stickler would
On 2020-Mar-11, Tom Lane wrote:
> > thanks for it) to backbranches or just to master. It seems legitimate
> > to see it as a feature addition, but OTOH the overall feature is not
> > complete without it ...
>
> 0003 is the command addition to allow removing such a dependency,
> right? Given
Thanks for the reviews; I pushed 0001 now, again to all branches since
9.6. Because of the previous commit, the fact that multiple statements
are emitted is not important anymore: the server will only restore the
first one, and silently ignore subsequent ones. And once you're using a
system in
Alvaro Herrera writes:
> I'm still not sure whether to apply 0003 (+ your tab-completion patch,
> thanks for it) to backbranches or just to master. It seems legitimate
> to see it as a feature addition, but OTOH the overall feature is not
> complete without it ...
0003 is the command addition
On 2020-Mar-05, Alvaro Herrera wrote:
> On 2020-Mar-05, Ibrar Ahmed wrote:
>
> > Is this intentional that there is no error when removing a non-existing
> > dependency?
>
> Hmm, I think we can do nothing silently if nothing is called for.
> So, yes, that seems to be the way it should work.
I
On Thu, Mar 5, 2020 at 11:38 PM Alvaro Herrera
wrote:
> On 2020-Mar-05, Ibrar Ahmed wrote:
>
> > Is this intentional that there is no error when removing a non-existing
> > dependency?
>
> Hmm, I think we can do nothing silently if nothing is called for.
> So, yes, that seems to be the way it
On 2020-Mar-05, Ibrar Ahmed wrote:
> Is this intentional that there is no error when removing a non-existing
> dependency?
Hmm, I think we can do nothing silently if nothing is called for.
So, yes, that seems to be the way it should work.
--
Álvaro Herrera
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
It works for me
On Mon, Mar 2, 2020 at 12:45 PM Ahsan Hadi wrote:
>
>
> On Sat, Feb 29, 2020 at 2:38 AM Alvaro Herrera
> wrote:
>
>> On 2020-Feb-28, ahsan hadi wrote:
>>
>>
>> > Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON EXTENSION" in
>> case of indexes, functions, triggers etc. The "ALTER ..
On Sat, Feb 29, 2020 at 2:38 AM Alvaro Herrera
wrote:
> On 2020-Feb-28, ahsan hadi wrote:
>
>
> > Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON EXTENSION" in
> case of indexes, functions, triggers etc. The "ALTER .. DEPENDS ON
> EXTENSION" is included in the dump. However in some
On 2020-Feb-28, ahsan hadi wrote:
> Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON EXTENSION" in case
> of indexes, functions, triggers etc. The "ALTER .. DEPENDS ON EXTENSION" is
> included in the dump. However in some case not sure why "ALTER
> INDEX.DEPENDS ON EXTENSION" is
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON
On 2020-Feb-17, Alvaro Herrera wrote:
> * More than one 'x' dependencies are allowed for the same object on the
> same extension. That's useless and polluting, so should be prevented.
>
> * There's no way to remove an 'x' dependency.
Here's these two patches. There's an "if (true)" in 0002
ALTER ... DEPENDS ON EXTENSION (dependencies of type 'x' on an
extension) was found to have a few problems. One was fixed as
CVE-2020-1720. Other issues:
* pg_dump does not reproduce database state correctly.
The attached fixes it.
* More than one 'x' dependencies are allowed for the
17 matches
Mail list logo
