Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2023-01-12 Thread vignesh C
On Thu, 12 Jan 2023 at 05:22, Michael Paquier wrote: > > On Wed, Jan 11, 2023 at 10:29:25PM +0530, vignesh C wrote: > > I too felt keeping it simpler is better. How about using the simple > > first version of patch itself? > > Okay, I have just done that, then, after checking that all the object

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2023-01-11 Thread Michael Paquier
On Wed, Jan 11, 2023 at 10:29:25PM +0530, vignesh C wrote: > I too felt keeping it simpler is better. How about using the simple > first version of patch itself? Okay, I have just done that, then, after checking that all the object types were covered (28). Note that PROCEDURAL LANGUAGE has been

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2023-01-11 Thread vignesh C
On Wed, 11 Jan 2023 at 12:19, Michael Paquier wrote: > > On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote: > > It suggests the *kinds* of objects that are part of the extension, but > > lists the objects of that kind regardless of dependency. I read > > Michael suggested (and I

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2023-01-10 Thread Michael Paquier
On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote: > It suggests the *kinds* of objects that are part of the extension, but > lists the objects of that kind regardless of dependency. I read > Michael suggested (and I agree) to restrict the objects (not kinds) to > actually be a

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2023-01-10 Thread Kyotaro Horiguchi
At Mon, 2 Jan 2023 13:19:50 +0530, vignesh C wrote in > On Mon, 5 Dec 2022 at 06:53, Michael Paquier wrote: > > > > The DROP could be matched with the objects that are actually part of > > the so-said extension? > > The modified v2 version has the changes to handle the same. Sorry for > the

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2023-01-01 Thread vignesh C
On Mon, 5 Dec 2022 at 06:53, Michael Paquier wrote: > > On Sat, Dec 03, 2022 at 05:34:57PM +, Matheus Alcantara wrote: > > I've tested your patched on current master and seems to be working properly. > > > > I'm starting reviewing some patches here, let's see what more experience > > hackers

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2022-12-04 Thread Michael Paquier
On Sat, Dec 03, 2022 at 05:34:57PM +, Matheus Alcantara wrote: > I've tested your patched on current master and seems to be working properly. > > I'm starting reviewing some patches here, let's see what more experience > hackers > has to say about this, but as far I can tell is that is

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2022-12-03 Thread Matheus Alcantara
--- Original Message --- On Sunday, November 27th, 2022 at 10:24, vignesh C wrote: > Hi, > > Tab completion for ALTER EXTENSION ADD and DROP was missing, this > patch adds the tab completion for the same. > > Regards, > Vignesh Hi Vignesh I've tested your patched on current master

mprove tab completion for ALTER EXTENSION ADD/DROP

2022-11-27 Thread vignesh C
Hi, Tab completion for ALTER EXTENSION ADD and DROP was missing, this patch adds the tab completion for the same. Regards, Vignesh From 35e9e8bd22ae8767baa95a04c41ee8f68a9c5338 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Sat, 26 Nov 2022 20:18:58 +0530 Subject: [PATCH v1] Missing tab