Re: pg_basebackup check vs Windows file path limits

2023-11-15 Thread Andrew Dunstan
On 2023-11-15 We 06:34, Alvaro Herrera wrote: On 2023-Nov-13, Andrew Dunstan wrote: size? https://learn.microsoft.com/en-us/windows/win32/api/ioapiset/nf-ioapiset-deviceiocontrol Hmm, here's what that page says - I can't see it saying what you're suggesting here - am I missing something?:

Re: pg_basebackup check vs Windows file path limits

2023-11-15 Thread Alvaro Herrera
On 2023-Nov-13, Andrew Dunstan wrote: > > size? > > > > https://learn.microsoft.com/en-us/windows/win32/api/ioapiset/nf-ioapiset-deviceiocontrol > > Hmm, here's what that page says - I can't see it saying what you're > suggesting here - am I missing something?: I don't think so. I think I

Re: pg_basebackup check vs Windows file path limits

2023-11-13 Thread Andrew Dunstan
On 2023-11-11 Sa 11:31, Alvaro Herrera wrote: On 2023-Jul-08, Andrew Dunstan wrote: # Running: pg_basebackup -D C:\\tools\\nmsys64\\home\\pgrunner\\bf\\root\\REL_16_STABLE\\pgsql.build/testrun/pg_basebackup/010_pg_basebackup/data/t_010_pg_basebackup_main_data/backup/tarbackup2 -h

Re: pg_basebackup check vs Windows file path limits

2023-11-12 Thread Andrew Dunstan
On 2023-11-11 Sa 12:00, Alexander Lakhin wrote: 11.11.2023 18:18, Andrew Dunstan wrote: Hmm, maybe we should be using File::Copy::move() instead of rename(). The docco for that says:     If possible, move() will simply rename the file. Otherwise, it     copies the file to the new

Re: pg_basebackup check vs Windows file path limits

2023-11-11 Thread Alexander Lakhin
11.11.2023 18:18, Andrew Dunstan wrote: Hmm, maybe we should be using File::Copy::move() instead of rename(). The docco for that says:     If possible, move() will simply rename the file. Otherwise, it     copies the file to the new location and deletes the original. If an    

Re: pg_basebackup check vs Windows file path limits

2023-11-11 Thread Alvaro Herrera
On 2023-Jul-08, Andrew Dunstan wrote: > # Running: pg_basebackup -D > C:\\tools\\nmsys64\\home\\pgrunner\\bf\\root\\REL_16_STABLE\\pgsql.build/testrun/pg_basebackup/010_pg_basebackup/data/t_010_pg_basebackup_main_data/backup/tarbackup2 > -h C:/tools/nmsys64/tmp/63ohSgsh21 -p 54699 --checkpoint

Re: pg_basebackup check vs Windows file path limits

2023-11-11 Thread Andrew Dunstan
Hi, Alexander On 2023-11-11 Sa 08:00, Alexander Lakhin wrote: Hello Andrew, 08.07.2023 18:52, Andrew Dunstan wrote: Since this test is passing on HEAD which has slightly shorter paths, I'm wondering if we should change this: rename("$pgdata/pg_replslot", "$tempdir/pg_replslot")  

Re: pg_basebackup check vs Windows file path limits

2023-11-11 Thread Alexander Lakhin
Hello Andrew, 08.07.2023 18:52, Andrew Dunstan wrote: Since this test is passing on HEAD which has slightly shorter paths, I'm wondering if we should change this: rename("$pgdata/pg_replslot", "$tempdir/pg_replslot")   or BAIL_OUT "could not move $pgdata/pg_replslot";

Re: pg_basebackup check vs Windows file path limits

2023-07-08 Thread Andrew Dunstan
On 2023-07-08 Sa 09:15, Andrew Dunstan wrote: On 2023-07-06 Th 12:38, Andrew Dunstan wrote: On 2023-07-06 Th 09:50, Daniel Gustafsson wrote: On 5 Jul 2023, at 14:49, Andrew Dunstan wrote: On 2023-07-04 Tu 16:54, Daniel Gustafsson wrote: On 4 Jul 2023, at 20:19, Andrew Dunstan wrote:

Re: pg_basebackup check vs Windows file path limits

2023-07-08 Thread Andrew Dunstan
On 2023-07-06 Th 12:38, Andrew Dunstan wrote: On 2023-07-06 Th 09:50, Daniel Gustafsson wrote: On 5 Jul 2023, at 14:49, Andrew Dunstan wrote: On 2023-07-04 Tu 16:54, Daniel Gustafsson wrote: On 4 Jul 2023, at 20:19, Andrew Dunstan wrote: But sadly we're kinda back where we started.

Re: pg_basebackup check vs Windows file path limits

2023-07-06 Thread Andrew Dunstan
On 2023-07-06 Th 09:50, Daniel Gustafsson wrote: On 5 Jul 2023, at 14:49, Andrew Dunstan wrote: On 2023-07-04 Tu 16:54, Daniel Gustafsson wrote: On 4 Jul 2023, at 20:19, Andrew Dunstan wrote: But sadly we're kinda back where we started. fairywren is failing on REL_16_STABLE. Before the

Re: pg_basebackup check vs Windows file path limits

2023-07-06 Thread Daniel Gustafsson
> On 5 Jul 2023, at 14:49, Andrew Dunstan wrote: > On 2023-07-04 Tu 16:54, Daniel Gustafsson wrote: >>> On 4 Jul 2023, at 20:19, Andrew Dunstan >>> wrote: >>> >>> But sadly we're kinda back where we started. fairywren is failing on >>> REL_16_STABLE. Before the changes the failure occurred

Re: pg_basebackup check vs Windows file path limits

2023-07-05 Thread Andrew Dunstan
On 2023-07-04 Tu 16:54, Daniel Gustafsson wrote: On 4 Jul 2023, at 20:19, Andrew Dunstan wrote: But sadly we're kinda back where we started. fairywren is failing on REL_16_STABLE. Before the changes the failure occurred because the test script was unable to create the file with a path > 255.

Re: pg_basebackup check vs Windows file path limits

2023-07-04 Thread Daniel Gustafsson
> On 4 Jul 2023, at 20:19, Andrew Dunstan wrote: > But sadly we're kinda back where we started. fairywren is failing on > REL_16_STABLE. Before the changes the failure occurred because the test > script was unable to create the file with a path > 255. Now that we have a > way to create the

Re: pg_basebackup check vs Windows file path limits

2023-07-04 Thread Andrew Dunstan
On 2023-07-03 Mo 11:18, Andrew Dunstan wrote: On 2023-07-03 Mo 10:16, Daniel Gustafsson wrote: On 3 Jul 2023, at 16:12, Andrew Dunstan wrote: I've pushed a better solution, which creates the file via a short symlink. Experimentation on fairywren showed this working. The buildfarm seems a

Re: pg_basebackup check vs Windows file path limits

2023-07-03 Thread Daniel Gustafsson
> On 3 Jul 2023, at 17:18, Andrew Dunstan wrote: > On 2023-07-03 Mo 10:16, Daniel Gustafsson wrote: >>> On 3 Jul 2023, at 16:12, Andrew Dunstan >>> wrote: >>> >>> I've pushed a better solution, which creates the file via a short symlink. >>> Experimentation on fairywren showed this working.

Re: pg_basebackup check vs Windows file path limits

2023-07-03 Thread Andrew Dunstan
On 2023-07-03 Mo 10:16, Daniel Gustafsson wrote: On 3 Jul 2023, at 16:12, Andrew Dunstan wrote: I've pushed a better solution, which creates the file via a short symlink. Experimentation on fairywren showed this working. The buildfarm seems a tad upset after this? Yeah :-( I think it

Re: pg_basebackup check vs Windows file path limits

2023-07-03 Thread Daniel Gustafsson
> On 3 Jul 2023, at 16:12, Andrew Dunstan wrote: > I've pushed a better solution, which creates the file via a short symlink. > Experimentation on fairywren showed this working. The buildfarm seems a tad upset after this? -- Daniel Gustafsson

Re: pg_basebackup check vs Windows file path limits

2023-07-03 Thread Andrew Dunstan
On 2023-07-02 Su 09:15, Andrew Dunstan wrote: The buildfarm animal fairywren has been failing the tests for pg_basebackup because it can't create a file with a path longer than 255 chars. This has just been tripped because for release 16 it's running TAP tests, and the branch name is part

pg_basebackup check vs Windows file path limits

2023-07-02 Thread Andrew Dunstan
The buildfarm animal fairywren has been failing the tests for pg_basebackup because it can't create a file with a path longer than 255 chars. This has just been tripped because for release 16 it's running TAP tests, and the branch name is part of the file path, and "REL_16_STABLE" is longer