Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-22 Thread Julien Rouhaud
On Thu, May 21, 2020 at 7:39 PM Piotr Stefaniak wrote: > > On 18/05/2020 11.22, Julien Rouhaud wrote: > > On Sun, May 17, 2020 at 2:32 AM Michael Paquier wrote: > >> > >> On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote: > >>> In the meantime, I went ahead and pushed this to our

Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-21 Thread Piotr Stefaniak
On 18/05/2020 11.22, Julien Rouhaud wrote: On Sun, May 17, 2020 at 2:32 AM Michael Paquier wrote: On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote: In the meantime, I went ahead and pushed this to our pg_bsd_indent repo. Thanks, Tom. +1, thanks a lot! Committed upstream, thank

Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-18 Thread Julien Rouhaud
On Sun, May 17, 2020 at 2:32 AM Michael Paquier wrote: > > On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote: > > In the meantime, I went ahead and pushed this to our pg_bsd_indent repo. > > Thanks, Tom. +1, thanks a lot!

Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-16 Thread Michael Paquier
On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote: > In the meantime, I went ahead and pushed this to our pg_bsd_indent repo. Thanks, Tom. -- Michael signature.asc Description: PGP signature

Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-16 Thread Tom Lane
Julien Rouhaud writes: > On Fri, May 15, 2020 at 9:17 AM Daniel Gustafsson wrote: >> On 15 May 2020, at 08:28, Julien Rouhaud wrote: >>> The patch looks good to me. It looks like we already have custom >>> patches, so +1 to applying it. >> Shouldn't we try and propose it to upstream first to

Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-15 Thread Julien Rouhaud
On Fri, May 15, 2020 at 9:17 AM Daniel Gustafsson wrote: > > > On 15 May 2020, at 08:28, Julien Rouhaud wrote: > > On Fri, May 15, 2020 at 8:03 AM Michael Paquier wrote: > > >> Something like the attached is fine to take care of those warnings, > >> but what's our current patching policy for

Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-15 Thread Daniel Gustafsson
> On 15 May 2020, at 08:28, Julien Rouhaud wrote: > On Fri, May 15, 2020 at 8:03 AM Michael Paquier wrote: >> Something like the attached is fine to take care of those warnings, >> but what's our current patching policy for this tool? > > The patch looks good to me. It looks like we already

Re: pg_bsd_indent and -Wimplicit-fallthrough

2020-05-15 Thread Julien Rouhaud
On Fri, May 15, 2020 at 8:03 AM Michael Paquier wrote: > > Hi, > > I have just noticed that pg_bsd_indent complains since > -Wimplicit-fallthrough=3 has been added to the default set of switches > if available. Oh Indeed. > Something like the attached is fine to take c

pg_bsd_indent and -Wimplicit-fallthrough

2020-05-15 Thread Michael Paquier
Hi, I have just noticed that pg_bsd_indent complains since -Wimplicit-fallthrough=3 has been added to the default set of switches if available. Something like the attached is fine to take care of those warnings, but what's our current patching policy for this tool? Thanks, -- Michael diff --git