> On 19 Dec 2022, at 01:39, Shinoda, Noriyoshi (PN Japan FSIP)
> wrote:
> With the addition of --copy option, pg_upgrade now has three possible
> transfer mode options. Currently, an error does not occur even if multiple
> transfer modes are specified. For example, we can also run "pg_upgrade
er Eisentraut
Sent: Saturday, December 17, 2022 2:44 AM
To: Daniel Gustafsson
Cc: PostgreSQL Hackers
Subject: Re: pg_upgrade: Make testing different transfer modes easier
On 14.12.22 10:40, Daniel Gustafsson wrote:
>> On 14 Dec 2022, at 08:04, Peter Eisentraut
>> wrote:
>>
>&g
On 14.12.22 10:40, Daniel Gustafsson wrote:
On 14 Dec 2022, at 08:04, Peter Eisentraut
wrote:
On 07.12.22 17:33, Peter Eisentraut wrote:
I think if we want to make this configurable on the fly, and environment
variable would be much easier, like
my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE}
> On 15 Dec 2022, at 01:56, Kyotaro Horiguchi wrote:
>
> At Wed, 14 Dec 2022 10:40:45 +0100, Daniel Gustafsson wrote
> in
>>> On 14 Dec 2022, at 08:04, Peter Eisentraut
>>> wrote:
>>>
>>> On 07.12.22 17:33, Peter Eisentraut wrote:
I think if we want to make this configurable on the
At Wed, 14 Dec 2022 10:40:45 +0100, Daniel Gustafsson wrote
in
> > On 14 Dec 2022, at 08:04, Peter Eisentraut
> > wrote:
> >
> > On 07.12.22 17:33, Peter Eisentraut wrote:
> >> I think if we want to make this configurable on the fly, and environment
> >> variable would be much easier, like
> On 14 Dec 2022, at 08:04, Peter Eisentraut
> wrote:
>
> On 07.12.22 17:33, Peter Eisentraut wrote:
>> I think if we want to make this configurable on the fly, and environment
>> variable would be much easier, like
>> my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy';
>
> Here is an
77cf8ade59c4bb61c4064b Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 14 Dec 2022 08:02:57 +0100
Subject: [PATCH v2 2/2] pg_upgrade: Make testing different transfer modes
easier
The environment variable PG_TEST_PG_UPGRADE_MODE can be set to
override the default transfer mode for the pg_u
On 02.12.22 13:04, Daniel Gustafsson wrote:
Wouldn't it be possible, and less change-code-manual, to accept this via an
extension to PROVE_FLAGS? Any options after :: to prove are passed to the
test(s) [0] so we could perhaps inspect @ARGV for the mode if we invent a new
way to pass arguments.
On 02.12.22 01:56, Kyotaro Horiguchi wrote:
also thought about something like a "mode" option with an argument,
but given that we already have --link and --clone, this seemed the
most sensible.)
Thoughts?
When I read up to the point of the --copy option, what came to my mind
was the --mode=
> On 1 Dec 2022, at 16:18, Peter Eisentraut
> wrote:
>
> I wanted to test the different pg_upgrade transfer modes (--link, --clone),
> but that was not that easy, because there is more than one place in the test
> script you have to find and manually change. So I wrote a little patch to
>
At Thu, 1 Dec 2022 16:18:21 +0100, Peter Eisentraut
wrote in
> I wanted to test the different pg_upgrade transfer modes (--link,
> --clone), but that was not that easy, because there is more than one
> place in the test script you have to find and manually change. So I
> wrote a little patch
From b87a6bbb293deb94693774fa7b5c1e4918704f57 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 1 Dec 2022 15:36:12 +0100
Subject: [PATCH 2/2] pg_upgrade: Make testing different transfer modes easier
It still requires a manual change in the test script, but now there is
only one well-ma
12 matches
Mail list logo
