On Wed, Oct 2, 2019 at 3:58 PM Michael Paquier wrote:
>
> On Mon, Sep 30, 2019 at 05:07:08PM +0900, Masahiko Sawada wrote:
> > Thank you for updating! The comment in your patch is much better.
>
> Thanks, done and back-patched down to 9.5.
Thank you!
Regards,
--
Masahiko Sawada
On Mon, Sep 30, 2019 at 05:07:08PM +0900, Masahiko Sawada wrote:
> Thank you for updating! The comment in your patch is much better.
Thanks, done and back-patched down to 9.5.
--
Michael
signature.asc
Description: PGP signature
On Mon, Sep 30, 2019 at 5:03 PM Michael Paquier wrote:
>
> On Mon, Sep 30, 2019 at 12:53:58PM +0900, Masahiko Sawada wrote:
> > I think that the above checks are always true because isnt() function
> > checks if the 1st argument and 2nd argument are not the same.
>
> Dammit. I overlooked this
On Mon, Sep 30, 2019 at 12:53:58PM +0900, Masahiko Sawada wrote:
> I think that the above checks are always true because isnt() function
> checks if the 1st argument and 2nd argument are not the same.
Dammit. I overlooked this part of the module's doc.
> I've attached the updated version patch
On Mon, Sep 30, 2019 at 10:10 AM Michael Paquier wrote:
>
> On Fri, Sep 27, 2019 at 10:00:16PM +0900, Masahiko Sawada wrote:
> > I abandoned once to move the removal code to between
> > writeTimeLineHistory() and timeline switching because of expanding the
> > window but since unlink itself will
On Fri, Sep 27, 2019 at 10:00:16PM +0900, Masahiko Sawada wrote:
> I abandoned once to move the removal code to between
> writeTimeLineHistory() and timeline switching because of expanding the
> window but since unlink itself will complete within a very short time
> it would not be problamatic
On Fri, Sep 27, 2019 at 8:41 PM Fujii Masao wrote:
>
> On Fri, Sep 27, 2019 at 7:16 PM Michael Paquier wrote:
> >
> > On Fri, Sep 27, 2019 at 05:58:21PM +0900, Fujii Masao wrote:
> > > So you think that it's better to remove them just after
> > > writeTimeLineHistory()?
> > > Per the following
On Fri, Sep 27, 2019 at 7:16 PM Michael Paquier wrote:
>
> On Fri, Sep 27, 2019 at 05:58:21PM +0900, Fujii Masao wrote:
> > So you think that it's better to remove them just after
> > writeTimeLineHistory()?
> > Per the following Sawada-san's comment, I was thinking that idea is
> > basically
>
On Fri, Sep 27, 2019 at 05:58:21PM +0900, Fujii Masao wrote:
> So you think that it's better to remove them just after
> writeTimeLineHistory()?
> Per the following Sawada-san's comment, I was thinking that idea is basically
> not good. And, RemoveNonParentXlogFiles() also removes garbage files
On Fri, Sep 27, 2019 at 5:09 PM Michael Paquier wrote:
>
> On Fri, Sep 27, 2019 at 01:51:25PM +0900, Masahiko Sawada wrote:
> > On Thu, Sep 26, 2019 at 6:23 PM Fujii Masao wrote:
> >> What about moving the logic that removes RECO VERYXLOG and
> >> RECOVERYHISTORY from exitArchiveRecovery() and
On Fri, Sep 27, 2019 at 01:51:25PM +0900, Masahiko Sawada wrote:
> On Thu, Sep 26, 2019 at 6:23 PM Fujii Masao wrote:
>> What about moving the logic that removes RECO VERYXLOG and
>> RECOVERYHISTORY from exitArchiveRecovery() and performing it
>> just before/after RemoveNonParentXlogFiles()?
On Thu, Sep 26, 2019 at 6:23 PM Fujii Masao wrote:
>
> On Thu, Sep 26, 2019 at 5:15 PM Masahiko Sawada wrote:
> >
> > Hi,
> >
> > When we do archive recovery from the database cluster of which
> > timeline ID is more than 2 pg_wal/RECOVERYHISTORY is remained even
> > after archive recovery
On Thu, Sep 26, 2019 at 5:15 PM Masahiko Sawada wrote:
>
> Hi,
>
> When we do archive recovery from the database cluster of which
> timeline ID is more than 2 pg_wal/RECOVERYHISTORY is remained even
> after archive recovery completed.
>
> The cause of this seems cbc55da556b that moved
Hi,
When we do archive recovery from the database cluster of which
timeline ID is more than 2 pg_wal/RECOVERYHISTORY is remained even
after archive recovery completed.
The cause of this seems cbc55da556b that moved exitArchiveRecovery()
to before writeTimeLineHistory(). writeTimeLineHIstory()
14 matches
Mail list logo
