Re: pgindent (probably my missing something obvious)

2023-07-03 Thread Tom Lane
James Coleman writes: > My heuristic for what pgindent changes must be wrong. The long > function calls (and 'if' conditions) seem obviously out of place to my > eyes with the surrounding code. Does that mean the surrounding code > was just hand-prettified? pgindent won't usually editorialize on

Re: pgindent (probably my missing something obvious)

2023-07-03 Thread James Coleman
On Mon, Jul 3, 2023 at 9:20 PM Tom Lane wrote: > > James Coleman writes: > > This is the first time I've run pgindent on my current machine, and it > > doesn't seem to be making any modifications to source files. For > > example this command: > > > ./src/tools/pgindent/pgindent src/backend/optimi

Re: pgindent (probably my missing something obvious)

2023-07-03 Thread Tom Lane
James Coleman writes: > This is the first time I've run pgindent on my current machine, and it > doesn't seem to be making any modifications to source files. For > example this command: > ./src/tools/pgindent/pgindent src/backend/optimizer/path/allpaths.c > leaves the allpaths.c file unchanged d

pgindent (probably my missing something obvious)

2023-07-03 Thread James Coleman
Hello, This is the first time I've run pgindent on my current machine, and it doesn't seem to be making any modifications to source files. For example this command: ./src/tools/pgindent/pgindent src/backend/optimizer/path/allpaths.c leaves the allpaths.c file unchanged despite my having some ver