Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

2022-09-06 Thread Amit Kapila
On Tue, Sep 6, 2022 at 7:40 PM Masahiko Sawada wrote: > > > > I think they should say something like > > > > > > "logical replication starts skipping transaction with LSN %X/%X" > > > "logical replication completed skipping transaction with LSN %X/%X" > > > > > > > This looks better to me. > > +1

Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

2022-09-06 Thread Masahiko Sawada
On Sun, Sep 4, 2022 at 8:39 PM Amit Kapila wrote: > > On Sun, Sep 4, 2022 at 1:48 PM Alvaro Herrera wrote: > > > > On 2022-Mar-22, Amit Kapila wrote: > > > > > Add ALTER SUBSCRIPTION ... SKIP. > > > > There are two messages here that seem oddly worded. > > > > msgid "start skipping logical

Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

2022-09-04 Thread Amit Kapila
On Sun, Sep 4, 2022 at 1:48 PM Alvaro Herrera wrote: > > On 2022-Mar-22, Amit Kapila wrote: > > > Add ALTER SUBSCRIPTION ... SKIP. > > There are two messages here that seem oddly worded. > > msgid "start skipping logical replication transaction finished at %X/%X" > msgid "done skipping logical

Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

2022-09-04 Thread Alvaro Herrera
On 2022-Mar-22, Amit Kapila wrote: > Add ALTER SUBSCRIPTION ... SKIP. There are two messages here that seem oddly worded. msgid "start skipping logical replication transaction finished at %X/%X" msgid "done skipping logical replication transaction finished at %X/%X" Two complaints here.