Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-09 Thread Michael Paquier
On Tue, Jan 09, 2018 at 12:49:11PM -0500, Peter Eisentraut wrote: > Committed. I like counter-patches. > > (I renamed the function a bit to check_pg_config, to make the naming > similar to other functions in TestLib.) Thanks for committing. I think that you should have authorship as well, which

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-09 Thread Peter Eisentraut
On 1/8/18 08:14, Michael Paquier wrote: > On Sat, Jan 06, 2018 at 09:10:51AM +0900, Michael Paquier wrote: >> On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera >> wrote: >> Good idea as a whole, but I don't think this is the right approach. As >> we include $(bindir) in PATH when running the prove c

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-08 Thread Michael Paquier
On Sat, Jan 06, 2018 at 09:10:51AM +0900, Michael Paquier wrote: > On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera > wrote: > Good idea as a whole, but I don't think this is the right approach. As > we include $(bindir) in PATH when running the prove command, why not > getting the include path fro

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-05 Thread Michael Paquier
On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> On 1/5/18 09:28, Michael Paquier wrote: >> > In order to do things cleanly, we should make this TAP test >> > conditional on the version of OpenSSL. >> >> How about looking into pg_config.h, like in the attached pat

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-05 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 1/5/18 09:28, Michael Paquier wrote: > > In order to do things cleanly, we should make this TAP test > > conditional on the version of OpenSSL. > > How about looking into pg_config.h, like in the attached patch? I suppose if this starts to spread, we'll come up with a

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-05 Thread Peter Eisentraut
On 1/5/18 09:28, Michael Paquier wrote: > In order to do things cleanly, we should make this TAP test > conditional on the version of OpenSSL. How about looking into pg_config.h, like in the attached patch? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-05 Thread Michael Paquier
On Fri, Jan 5, 2018 at 10:47 PM, Robert Haas wrote: > The SSL tests on chipmunk failed in the last run. I assume that's > probably the fault of this patch, or one of the follow-on commits: Thanks for the heads-up, Robert. I did not notice the failure. That's the fault of 054e8c6c. Raspbian is us

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-05 Thread Robert Haas
On Thu, Jan 4, 2018 at 4:09 PM, Thomas Munro wrote: > On Fri, Jan 5, 2018 at 9:36 AM, Peter Eisentraut wrote: >> Implement channel binding tls-server-end-point for SCRAM > > FYI some BF animals are saying: > > libpq/be-secure-openssl.o: In function `be_tls_get_certificate_hash': > /home/pgbuildfa