Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-11 Thread Christoph Berg
Re: Tom Lane 2019-10-10 <10247.1570731...@sss.pgh.pa.us> > OK, done. Thanks, that made quite a few QA pipeline jobs happy here. Christoph

Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-10 Thread Tom Lane
Stephen Frost writes: > Yes, this is absolutely the right answer, we shouldn't be removing > symbols without an SONAME bump. If we don't want to bump the SONAME, > then don't remove the symbol. OK, done. regards, tom lane

Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-09 Thread Michael Paquier
On Wed, Oct 09, 2019 at 09:37:34AM -0400, Stephen Frost wrote: > Yes, this is absolutely the right answer, we shouldn't be removing > symbols without an SONAME bump. If we don't want to bump the SONAME, > then don't remove the symbol. This is utterly basic proper library > maintenance and it isn'

Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-09 Thread Stephen Frost
Greetings, * Christoph Berg (m...@debian.org) wrote: > Re: Tom Lane 2019-10-08 <9333.1570566...@sss.pgh.pa.us> > > Having said all that, if we conclude we can't break compatibility > > with this legacy code quite yet, I'd be inclined to put a > > separate, clearly-marked-as-legacy-code version of

Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-09 Thread Christoph Berg
Re: Tom Lane 2019-10-08 <9333.1570566...@sss.pgh.pa.us> > Having said all that, if we conclude we can't break compatibility > with this legacy code quite yet, I'd be inclined to put a > separate, clearly-marked-as-legacy-code version of pqsignal() > back into libpq, using the pre-9.3 SA_RESTART sem

Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-08 Thread Tom Lane
Christoph Berg writes: > Re: Tom Lane 2018-09-28 >> Remove pqsignal() from libpq's official exports list. > This is starting to hurt in several places: > 04 11:41 mha@xindi:~$ psql > 04 11:41 /usr/lib/postgresql/9.2/bin/psql: symbol lookup error: >/usr/lib/postgresql/9.2/bi

Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-07 Thread Michael Paquier
On Fri, Oct 04, 2019 at 11:56:31AM +0200, Christoph Berg wrote: > This is starting to hurt in several places: > > 04 11:41 mha@xindi:~$ psql > 04 11:41 /usr/lib/postgresql/9.2/bin/psql: symbol lookup error: >/usr/lib/postgresql/9.2/bin/psql: undefined symbol: > pqsignal > >

Re: pgsql: Remove pqsignal() from libpq's official exports list.

2019-10-04 Thread Christoph Berg
Re: Tom Lane 2018-09-28 > Remove pqsignal() from libpq's official exports list. > > Client applications should get this function, if they need it, from > libpgport. > > The fact that it's exported from libpq is a hack left over from before > we set up libpgport. It's never been documented, and