Re: pgsql: Use CompactAttribute more often, when possible

2025-10-23 Thread David Rowley
On Fri, 24 Oct 2025 at 01:21, Robert Haas wrote: > David, I've noticed several times lately you've documented in commit > messages why you thought going further with some change would be > risky, and I really like that. I think sometimes we (as committers) > are sometimes reluctant to document cas

Re: pgsql: Use CompactAttribute more often, when possible

2025-10-23 Thread Robert Haas
On Tue, Oct 21, 2025 at 6:36 PM David Rowley wrote: > There are some locations where I've left the code using > FormData_pg_attribute. These are mostly in the ALTER TABLE code. Using > CompactAttribute here seems more risky as often the TupleDesc is being > changed and those changes may not have