Re: postgres_fdw - make cached connection functions tests meaningful

2021-07-21 Thread Bharath Rupireddy
On Sat, Jul 17, 2021 at 9:37 PM Tom Lane wrote: > > Bharath Rupireddy writes: > > On Thu, Jul 15, 2021 at 3:48 AM Tom Lane wrote: > >> More generally, though, I am not sure that I believe the premise of > >> this patch. AFAICS it's assuming that forcing debug_discard_caches > >> off guarantees

Re: postgres_fdw - make cached connection functions tests meaningful

2021-07-17 Thread Tom Lane
Bharath Rupireddy writes: > On Thu, Jul 15, 2021 at 3:48 AM Tom Lane wrote: >> More generally, though, I am not sure that I believe the premise of >> this patch. AFAICS it's assuming that forcing debug_discard_caches >> off guarantees zero cache flushes, which it does not. > Can the setting

Re: postgres_fdw - make cached connection functions tests meaningful

2021-07-17 Thread Bharath Rupireddy
On Thu, Jul 15, 2021 at 3:48 AM Tom Lane wrote: > > Bharath Rupireddy writes: > > While working on [1], I got to know that there is a new GUC > > debug_invalidate_system_caches_always that has been introduced in v14. > > It can be used to switch off cache invalidation in > > CLOBBER_CACHE_ALWAYS

Re: postgres_fdw - make cached connection functions tests meaningful

2021-07-15 Thread vignesh C
On Mon, May 10, 2021 at 6:03 PM Bharath Rupireddy wrote: > > Hi, > > While working on [1], I got to know that there is a new GUC > debug_invalidate_system_caches_always that has been introduced in v14. > It can be used to switch off cache invalidation in > CLOBBER_CACHE_ALWAYS builds which makes

Re: postgres_fdw - make cached connection functions tests meaningful

2021-07-14 Thread Tom Lane
Bharath Rupireddy writes: > While working on [1], I got to know that there is a new GUC > debug_invalidate_system_caches_always that has been introduced in v14. > It can be used to switch off cache invalidation in > CLOBBER_CACHE_ALWAYS builds which makes cache sensitive tests stable. > Using

postgres_fdw - make cached connection functions tests meaningful

2021-05-10 Thread Bharath Rupireddy
. EnterpriseDB: http://www.enterprisedb.com From a5ff26edbf54fca4d42833ef4aedf79bec9445bd Mon Sep 17 00:00:00 2001 From: Bharath Rupireddy Date: Sat, 8 May 2021 19:51:58 +0530 Subject: [PATCH v1] postgres_fdw-make cached connection functions tests meaningful The new GUC